webrtc: Require two code reviews if the uploader is not a webrtc committer.
Bug: b/356276881
Change-Id: I0e946652ac8fe407c331f009223e09edeb24efd6
Reviewed-on: https://webrtc-review.googlesource.com/c/All-Projects/+/359140
Reviewed-by: Joey Scarr <jsca@google.com>
Auto-Submit: Andrew Mitchell <mitchella@google.com>
diff --git a/project.config b/project.config
index d1b8700..452e3ee 100644
--- a/project.config
+++ b/project.config
@@ -70,7 +70,6 @@
addPatchSet = group cria/project-webrtc-committers
[access "refs/heads/*"]
label-Code-Review = -1..+1 group cria/project-webrtc-committers
- label-Code-Review = -1..+1 group cria/project-webrtc-googlers
submit = group cria/project-webrtc-committers
abandon = group cria/project-webrtc-committers
push = group cria/project-webrtc-admins
@@ -91,7 +90,7 @@
[plugin "jwtservice"]
audience = https://api.cr.dev
[submit-requirement "Code-Review"]
- description = At least one maximum vote for label 'Code-Review' is required
- submittableIf = label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN
+ description = If the author is a webrtc committer, code review is required from one other committer. Otherwise, code review is required from two committers.
+ submittableIf = ((uploaderin:cria/project-webrtc-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN
overrideIf = label:Bot-Commit=+1 AND -label:Code-Review=MIN
canOverrideInChildProjects = true
