Consider winsdk_samples a system library. Since these headers are not part of WebRTC, this CL tells clang to include them as system headers (in order to stop triggering warnings on them). This is part of the effort that will reduce the number of warnings suppression flags propagated in the WebRTC build graph (by config and public_configs). Bug: webrtc:9251, webrtc:6269 Change-Id: I3879fe90627cca982f7b360e7bd8ca11592515bc Reviewed-on: https://webrtc-review.googlesource.com/75514 Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
diff --git a/BUILD.gn b/BUILD.gn index 291a208..fc73edb 100644 --- a/BUILD.gn +++ b/BUILD.gn
@@ -10,30 +10,13 @@ baseclasses_dir = "Samples/multimedia/directshow/baseclasses" config("winsdk_samples_config") { - include_dirs = [ baseclasses_dir ] - } - - config("winsdk_samples_warnings_config") { if (is_win && is_clang) { cflags = [ - # Disable warnings failing when compiling with Clang on Windows. - # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366 - "-Wno-comment", - "-Wno-delete-non-virtual-dtor", - "-Wno-ignored-attributes", - "-Wno-logical-op-parentheses", - "-Wno-non-pod-varargs", - "-Wno-microsoft-extra-qualification", - "-Wno-missing-braces", - "-Wno-overloaded-virtual", - "-Wno-parentheses", - "-Wno-reorder", - "-Wno-string-conversion", - "-Wno-tautological-constant-out-of-range-compare", - "-Wno-unknown-pragmas", - "-Wno-unused-private-field", - "-Wno-writable-strings", + "-isystem", + rebase_path(baseclasses_dir, root_build_dir) ] + } else { + include_dirs = [ baseclasses_dir ] } } @@ -110,7 +93,6 @@ ] configs += [ "//build/config/compiler:no_chromium_code", - ":winsdk_samples_warnings_config", ] } }