)]}'
{
  "commit": "0242939296c0fd12e745d2f09d6256e390de8a2e",
  "tree": "2077ce35f75de761adfee428ee939fd29517ed80",
  "parents": [
    "17e358096ef31c75bb6bc6586a9b5946e2f52aee"
  ],
  "author": {
    "name": "Tomas Gunnarsson",
    "email": "tommi@webrtc.org",
    "time": "Thu Mar 07 15:24:55 2024"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Mar 08 20:39:59 2024"
  },
  "message": "Reland \"Deprecate old constructors and set_type() in Candidate and Port\"\n\nThis reverts commit ed8390d21a7b15091d01bc8e843193d0a6efd23a.\n\nReason for revert: Fix has landed in chrome, ready to reland.\n\nOriginal change\u0027s description:\n\u003e Revert \"Deprecate old constructors and set_type() in Candidate and Port\"\n\u003e\n\u003e This reverts commit aaa6851d53741179a591d79fc82c4dd6651a7ba5.\n\u003e\n\u003e Reason for revert: breaks chromium webrtc import\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Deprecate old constructors and set_type() in Candidate and Port\n\u003e \u003e\n\u003e \u003e * Deprecates constructors that use string based `type`\n\u003e \u003e * Deprecates string based type functions in favor of enum based.\n\u003e \u003e * Restrict possible values of Candidate::type. Ensure a valid value\n\u003e \u003e   is assigned at construction.\n\u003e \u003e * Make Port constructors protected to limit their use to subclasses.\n\u003e \u003e   - The reason for this is to make sure that use of SharedSocket()\n\u003e \u003e     is controlled (it adds a bit of complexity).\n\u003e \u003e * Simplify construction of Port (remove Construct() etc)\n\u003e \u003e\n\u003e \u003e Bug: webrtc:15846\n\u003e \u003e Change-Id: If24ed674e175642efa49da37fd2bc847dd14f613\n\u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339860\n\u003e \u003e Reviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\n\u003e \u003e Commit-Queue: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#41865}\n\u003e\n\u003e Bug: webrtc:15846\n\u003e Change-Id: Ic8b7cba97f8fb207ef51a88900e704658ade28b7\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342140\n\u003e Auto-Submit: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\n\u003e Owners-Override: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\n\u003e Commit-Queue: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\n\u003e Bot-Commit: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#41867}\n\nBug: webrtc:15846\nChange-Id: I3d52643bbb537d1c072643528828d26eb18fea94\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/342200\nReviewed-by: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\nCommit-Queue: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\nBot-Commit: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#41875}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "95359620c40285dc5cb93ba7a1232e19d3b62363",
      "old_mode": 33188,
      "old_path": "api/candidate.h",
      "new_id": "149da35fc6d7a133a9dbdaf671e4ed4d068752c8",
      "new_mode": 33188,
      "new_path": "api/candidate.h"
    },
    {
      "type": "modify",
      "old_id": "b6019406674e4e9efaf9048b56acff32b1cfe11f",
      "old_mode": 33188,
      "old_path": "p2p/base/connection.cc",
      "new_id": "996ea995c29c658ab663c6cac0a8670c4f4c2fb8",
      "new_mode": 33188,
      "new_path": "p2p/base/connection.cc"
    },
    {
      "type": "modify",
      "old_id": "a51a7ca4eeec3b2aa7ff9b13ead51ced659e103c",
      "old_mode": 33188,
      "old_path": "p2p/base/fake_port_allocator.h",
      "new_id": "9372c5ada0805c94bf1236c8f5226756cf205ebc",
      "new_mode": 33188,
      "new_path": "p2p/base/fake_port_allocator.h"
    },
    {
      "type": "modify",
      "old_id": "bd6f0bdb3a3b294e82add4d92f41437138324090",
      "old_mode": 33188,
      "old_path": "p2p/base/p2p_transport_channel.cc",
      "new_id": "07b6d2eb2d68c467cf2f4464ca7bf35f55c45da6",
      "new_mode": 33188,
      "new_path": "p2p/base/p2p_transport_channel.cc"
    },
    {
      "type": "modify",
      "old_id": "69ea4287e86a02a67e931d55fbbcccd848ced3c3",
      "old_mode": 33188,
      "old_path": "p2p/base/p2p_transport_channel_unittest.cc",
      "new_id": "e689ab0ad0b9deedca6f275989a6e8e6a2690a6b",
      "new_mode": 33188,
      "new_path": "p2p/base/p2p_transport_channel_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "917167c864253aa9dc529b2da9d5c4f7943fb1d0",
      "old_mode": 33188,
      "old_path": "p2p/base/port.cc",
      "new_id": "057ba741a3fb9ae463806eaa97e9fbf7a3904b6b",
      "new_mode": 33188,
      "new_path": "p2p/base/port.cc"
    },
    {
      "type": "modify",
      "old_id": "4021c250fb06b981ad83c3e8b4c07802ede99689",
      "old_mode": 33188,
      "old_path": "p2p/base/port.h",
      "new_id": "40e86793519aee66efbc9dfedf6b171157f06ec4",
      "new_mode": 33188,
      "new_path": "p2p/base/port.h"
    },
    {
      "type": "modify",
      "old_id": "2df8662f6265e917d96411c79464afdf431f19ee",
      "old_mode": 33188,
      "old_path": "p2p/base/port_allocator_unittest.cc",
      "new_id": "1b5584e2e8b3ece730672d5866184e6df5db1aa0",
      "new_mode": 33188,
      "new_path": "p2p/base/port_allocator_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "8a1d18d8ba21052dea997477e463ed34530d6817",
      "old_mode": 33188,
      "old_path": "p2p/base/port_interface.h",
      "new_id": "de68306acc281c15e16b5af8687ab74c0b80f64a",
      "new_mode": 33188,
      "new_path": "p2p/base/port_interface.h"
    },
    {
      "type": "modify",
      "old_id": "ab3ff86fd1ba10c1a1fc148c0f123984e8a47afc",
      "old_mode": 33188,
      "old_path": "p2p/base/port_unittest.cc",
      "new_id": "8e049b714582e0c3d2a8ea23ebae4765688d889b",
      "new_mode": 33188,
      "new_path": "p2p/base/port_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "648933fd9e13efd6fe51243f3a49c1d7fa950763",
      "old_mode": 33188,
      "old_path": "p2p/base/stun_port.cc",
      "new_id": "cf8830afffb01aa9b3698cc869bd487c524b3cb8",
      "new_mode": 33188,
      "new_path": "p2p/base/stun_port.cc"
    },
    {
      "type": "modify",
      "old_id": "a28983b040e5d0175f5affaf4e46b12b1ea46990",
      "old_mode": 33188,
      "old_path": "p2p/base/stun_port.h",
      "new_id": "f558b9266ff6206449eb343306a7012a5263abb1",
      "new_mode": 33188,
      "new_path": "p2p/base/stun_port.h"
    },
    {
      "type": "modify",
      "old_id": "948849800c8bfa92f7dc901ee383f733bdcd9228",
      "old_mode": 33188,
      "old_path": "p2p/base/tcp_port.cc",
      "new_id": "b1c94a6be721a180df7dde6f9e855aded0a8b8ef",
      "new_mode": 33188,
      "new_path": "p2p/base/tcp_port.cc"
    },
    {
      "type": "modify",
      "old_id": "bc35a2250a5e71cdc8a5a94d8e80437233ec92aa",
      "old_mode": 33188,
      "old_path": "p2p/base/turn_port.cc",
      "new_id": "965a68b3a39f100153219683c9e472341add3132",
      "new_mode": 33188,
      "new_path": "p2p/base/turn_port.cc"
    },
    {
      "type": "modify",
      "old_id": "169467d76cd3203fac47fadd73242c217fdecbd0",
      "old_mode": 33188,
      "old_path": "p2p/base/turn_port_unittest.cc",
      "new_id": "eaf28e4ce45cd91928422b9e9c043bd4ebb69249",
      "new_mode": 33188,
      "new_path": "p2p/base/turn_port_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c4b993d6873792e5b3485697309b19e963afc627",
      "old_mode": 33188,
      "old_path": "pc/jsep_session_description_unittest.cc",
      "new_id": "c3e1f330e4b9bff368f602b2629c8ecd234dfa4f",
      "new_mode": 33188,
      "new_path": "pc/jsep_session_description_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "5f6140da54f2537f0b5b5361060ba345a8e4c7f5",
      "old_mode": 33188,
      "old_path": "pc/legacy_stats_collector_unittest.cc",
      "new_id": "af3d3038e16f56ce309d622b28d53090aea7e8f7",
      "new_mode": 33188,
      "new_path": "pc/legacy_stats_collector_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "0db401276aecc3d815bcecc1b2c0cb30b3d5e6bf",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_bundle_unittest.cc",
      "new_id": "12ab99440e757fdd59e28a16f3e3e03d3fceedec",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_bundle_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "267cca4959dde1b0e78cec01f795f1e370684397",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_ice_unittest.cc",
      "new_id": "78d3103ab9bbf2e4eba78095c79a406956d51efc",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_ice_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "71542ca4bf9ff5b4fdb1dccd318928723c24e659",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector_unittest.cc",
      "new_id": "6c4cd69ea2c82d673fda6989264107b54c36619f",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ea9c8580cdb19ff9dccc799f394e7a233076c242",
      "old_mode": 33188,
      "old_path": "pc/webrtc_sdp.cc",
      "new_id": "b6cea4dfbfa043ac9b23d7538be2c1f6b167ad13",
      "new_mode": 33188,
      "new_path": "pc/webrtc_sdp.cc"
    },
    {
      "type": "modify",
      "old_id": "999f0b6b26e240ff4dfad611e951b12e64f9e13d",
      "old_mode": 33188,
      "old_path": "pc/webrtc_sdp_unittest.cc",
      "new_id": "afa2304666c0758aca10eebf7a517dce30b5da35",
      "new_mode": 33188,
      "new_path": "pc/webrtc_sdp_unittest.cc"
    }
  ]
}