| commit | 05255b0e8a4216a14e34b49ef8cbacb7defd8f3c | [log] [tgz] |
|---|---|---|
| author | perkj <perkj@webrtc.org> | Wed Apr 06 08:28:30 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Apr 06 08:28:34 2016 |
| tree | 215a16f7c588cc29337c7d8e2d07500af437a930 | |
| parent | efc38584b798cddf907e6cbf25c1309bd0ec362c [diff] |
Revert of Changed P2PTestConductor to use a separate WorkerThread. (patchset #1 id:1 of https://codereview.webrtc.org/1859933002/ ) Reason for revert: Causes P2PTestConductor.LocalP2PTestDtlsTransferCaller to fail on Win dbg. https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/7469/steps/peerconnection_unittests/logs/stdio e:\b\build\slave\win\build\src\webrtc\api\peerconnection_unittest.cc(1221): error: Value of: initiating_client_->ice_connection_state() Actual: 2 Expected: webrtc::PeerConnectionInterface::kIceConnectionCompleted Which is: 3 Original issue's description: > Changed P2PTestConductor to use a separate WorkerThread. > > P2PTestConductor currently use the current thread both as a signaling thread and a worker thread. Although convenient while debugging, it can also hide real bugs. An example is https://codereview.webrtc.org/1766653002/#ps420001 where the worker thread is deadlocked in the track proxy due to that the worker thread waits for the signaling thread but the proxy in turns invokes the worker thread..... That bug was only discovered on Android. I suggest we let the P2PTestConductor use a separate thread as a worker thread to better cover how PeerConnections are used in reality. > > BUG=webrtc:5426 > > Committed: https://crrev.com/6172401972c54813698d73580779d675d99178b4 > Cr-Commit-Position: refs/heads/master@{#12252} TBR=nisse@webrtc.org,pthatcher@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Review URL: https://codereview.webrtc.org/1866503003 Cr-Commit-Position: refs/heads/master@{#12255}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.