| commit | c2a0eb2699f7871c876a487105070f84c38a3dd0 | [log] [tgz] |
|---|---|---|
| author | Zijie He <zijiehe@google.com> | Thu Oct 26 20:46:17 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 26 21:14:57 2017 |
| tree | 705c981c7ab5b7e796ea9c0273f805b1a4f71fbd | |
| parent | 9828bebee69be2aabab7bcf0cffbfbc67edaf5ba [diff] |
[Window Capture] Mouse cursor missing during window sharing on Mac OSX CGWindowID is 32-bit, WindowId is 64-bit, using WindowId to receive int value from CFNumberGetValue() causes the top 32 bits to be random. WindowFinderMac is impacted by this issue and returns a random number. WindowCapturerMac cannot match the window_id_ with the the random number. Meanwhile MouseCursorMonitorMac uses window title to match "Dock" window. See, https://cs.chromium.org/chromium/src/third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm?rcl=a194e58e799ccab6c999998e5d0f75725aa3f748&l=174 This logic should not be necessary on 10.12 or upper, the name of dock window is not "Dock" anymore. But to ensure the consistency on old platforms, I have also added this logic back into GetWindowList() function. Bug: chromium:778049 Change-Id: Ie827bcd5d31f2ca69ff24c24cf640cb7cc50d419 Reviewed-on: https://webrtc-review.googlesource.com/15782 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#20451}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.