Remove BasicPortAllocator::EnableProtocol.
I'm not sure why we ever had this in the first place, and it confuses
people on a nearly weekly basis, so let's get rid of it. The protocols
are enabled right after the corresponding gathering is done, so the only
real effect it has is to produce confusing log messages (first
"candidate not signaled because protocol not enabled", then "protocol
enabled, signaling candidate" right afterwards).
BUG=None
Review-Url: https://codereview.webrtc.org/3018483002
Cr-Commit-Position: refs/heads/master@{#19873}
diff --git a/p2p/base/portallocator.h b/p2p/base/portallocator.h
index ec8da79..de8d2d9 100644
--- a/p2p/base/portallocator.h
+++ b/p2p/base/portallocator.h
@@ -448,6 +448,12 @@
void set_max_ipv6_networks(int networks) { max_ipv6_networks_ = networks; }
int max_ipv6_networks() { return max_ipv6_networks_; }
+ // Delay between different candidate gathering phases (UDP, TURN, TCP).
+ // Defaults to 1 second, but PeerConnection sets it to 50ms.
+ // TODO(deadbeef): Get rid of this. Its purpose is to avoid sending too many
+ // STUN transactions at once, but that's already happening if you configure
+ // multiple STUN servers or have multiple network interfaces. We should
+ // implement some global pacing logic instead if that's our goal.
uint32_t step_delay() const { return step_delay_; }
void set_step_delay(uint32_t delay) { step_delay_ = delay; }
