commit 22005ab39bc506c491bf62fce007bc340b8e6a79
author Philipp Hancke <phancke@microsoft.com> Wed Mar 08 15:45:02 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 13 14:49:05 2023
tree 3ade228351a00eddc7642b2623637252315e9f0f
parent 54199f9b4be54f5c0567d090f08041bcfc3e6c14

Remove obsolete header extension API names

and update spec link.

BUG=chromium:1051821

Change-Id: I42dbe36b2299f01cb4eb8010c893623fde7472fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296702
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39548}

api/rtp_transceiver_interface.h

diff --git a/api/rtp_transceiver_interface.h b/api/rtp_transceiver_interface.h
index b131f9e..1531c7f 100644
--- a/api/rtp_transceiver_interface.h
+++ b/api/rtp_transceiver_interface.h
@@ -153,45 +153,20 @@
   // with SetHeaderExtensionsToNegotiate, or a default set if it has not been
   // called.
   // https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
-  // TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
-  // virtual again.
   virtual std::vector<RtpHeaderExtensionCapability>
-  GetHeaderExtensionsToNegotiate() const {
-    return {};
-  }
-  virtual std::vector<RtpHeaderExtensionCapability> HeaderExtensionsToOffer()
-      const {
-    return GetHeaderExtensionsToNegotiate();
-  }
+  GetHeaderExtensionsToNegotiate() const = 0;
 
   // Returns either the empty set if negotation has not yet
   // happened, or a vector of the negotiated header extensions.
   // https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
-  // TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
-  // virtual again.
   virtual std::vector<RtpHeaderExtensionCapability>
-  GetNegotiatedHeaderExtensions() const {
-    return {};
-  }
-  virtual std::vector<RtpHeaderExtensionCapability> HeaderExtensionsNegotiated()
-      const {
-    return GetNegotiatedHeaderExtensions();
-  }
+  GetNegotiatedHeaderExtensions() const = 0;
 
   // The SetHeaderExtensionsToNegotiate method modifies the next SDP negotiation
   // so that it negotiates use of header extensions which are not kStopped.
   // https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
-  // TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
-  // virtual again.
   virtual webrtc::RTCError SetHeaderExtensionsToNegotiate(
-      rtc::ArrayView<const RtpHeaderExtensionCapability> header_extensions) {
-    return RTCError::OK();
-  }
-  virtual webrtc::RTCError SetOfferedRtpHeaderExtensions(
-      rtc::ArrayView<const RtpHeaderExtensionCapability>
-          header_extensions_to_offer) {
-    return SetHeaderExtensionsToNegotiate(header_extensions_to_offer);
-  }
+      rtc::ArrayView<const RtpHeaderExtensionCapability> header_extensions) = 0;
 
  protected:
   ~RtpTransceiverInterface() override = default;