commit 24744a9b5e549180e581ff809605adb086c18b5f
author Karl Wiberg <kwiberg@webrtc.org> Wed Aug 15 13:23:08 2018
committer Commit Bot <commit-bot@chromium.org> Mon Aug 20 08:19:03 2018
tree 1187080f6b06825c17caaec69816796f94ea5945
parent 1c0cf3101d330efbee49afc8a6dba210af500d45

Use string_view instead of overloading for const string& and const char*

Bug: none
Change-Id: Ia9e194cfcc2b6489d5d7c84baace67ad423111c2
Reviewed-on: https://webrtc-review.googlesource.com/85982
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24338}

DEPS

diff --git a/DEPS b/DEPS
index 2d81a24..8cf06aa 100644
--- a/DEPS
+++ b/DEPS
@@ -1046,6 +1046,7 @@
   # Abseil whitelist.
   "+absl/container/inlined_vector.h",
   "+absl/memory/memory.h",
+  "+absl/strings/string_view.h",
   "+absl/types/optional.h",
   "+absl/types/variant.h",
 ]

api/audio_codecs/BUILD.gn

diff --git a/api/audio_codecs/BUILD.gn b/api/audio_codecs/BUILD.gn
index 8e6a0f3..a7060a2 100644
--- a/api/audio_codecs/BUILD.gn
+++ b/api/audio_codecs/BUILD.gn
@@ -35,6 +35,7 @@
     "../../rtc_base:deprecation",
     "../../rtc_base:rtc_base_approved",
     "../../rtc_base:sanitizer",
+    "//third_party/abseil-cpp/absl/strings",
     "//third_party/abseil-cpp/absl/types:optional",
   ]
 }

api/audio_codecs/audio_format.cc

diff --git a/api/audio_codecs/audio_format.cc b/api/audio_codecs/audio_format.cc
index 9db5ce0..81ed299 100644
--- a/api/audio_codecs/audio_format.cc
+++ b/api/audio_codecs/audio_format.cc
@@ -17,26 +17,12 @@
 SdpAudioFormat::SdpAudioFormat(const SdpAudioFormat&) = default;
 SdpAudioFormat::SdpAudioFormat(SdpAudioFormat&&) = default;
 
-SdpAudioFormat::SdpAudioFormat(const char* name,
+SdpAudioFormat::SdpAudioFormat(absl::string_view name,
                                int clockrate_hz,
                                size_t num_channels)
     : name(name), clockrate_hz(clockrate_hz), num_channels(num_channels) {}
 
-SdpAudioFormat::SdpAudioFormat(const std::string& name,
-                               int clockrate_hz,
-                               size_t num_channels)
-    : name(name), clockrate_hz(clockrate_hz), num_channels(num_channels) {}
-
-SdpAudioFormat::SdpAudioFormat(const char* name,
-                               int clockrate_hz,
-                               size_t num_channels,
-                               const Parameters& param)
-    : name(name),
-      clockrate_hz(clockrate_hz),
-      num_channels(num_channels),
-      parameters(param) {}
-
-SdpAudioFormat::SdpAudioFormat(const std::string& name,
+SdpAudioFormat::SdpAudioFormat(absl::string_view name,
                                int clockrate_hz,
                                size_t num_channels,
                                const Parameters& param)

api/audio_codecs/audio_format.h

diff --git a/api/audio_codecs/audio_format.h b/api/audio_codecs/audio_format.h
index d132067d..aa5dbb1 100644
--- a/api/audio_codecs/audio_format.h
+++ b/api/audio_codecs/audio_format.h
@@ -15,6 +15,7 @@
 #include <string>
 #include <utility>
 
+#include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 #include "rtc_base/checks.h"
 
@@ -27,15 +28,8 @@
 
   SdpAudioFormat(const SdpAudioFormat&);
   SdpAudioFormat(SdpAudioFormat&&);
-  SdpAudioFormat(const char* name, int clockrate_hz, size_t num_channels);
-  SdpAudioFormat(const std::string& name,
-                 int clockrate_hz,
-                 size_t num_channels);
-  SdpAudioFormat(const char* name,
-                 int clockrate_hz,
-                 size_t num_channels,
-                 const Parameters& param);
-  SdpAudioFormat(const std::string& name,
+  SdpAudioFormat(absl::string_view name, int clockrate_hz, size_t num_channels);
+  SdpAudioFormat(absl::string_view name,
                  int clockrate_hz,
                  size_t num_channels,
                  const Parameters& param);