Avoid construction of unused RtcEventLogNullImpl object This CL addresses to nits: 1. When event_log_factory_ is not null, there's no need to create a RtcEventLogNullImpl object. 2. Use MakeUnique. BUG=None Review-Url: https://codereview.webrtc.org/3012763002 Cr-Commit-Position: refs/heads/master@{#19686}
diff --git a/webrtc/pc/peerconnectionfactory.cc b/webrtc/pc/peerconnectionfactory.cc index be083c2..d4ee405 100644 --- a/webrtc/pc/peerconnectionfactory.cc +++ b/webrtc/pc/peerconnectionfactory.cc
@@ -21,6 +21,7 @@ #include "webrtc/logging/rtc_event_log/rtc_event_log.h" #include "webrtc/rtc_base/bind.h" #include "webrtc/rtc_base/checks.h" +#include "webrtc/rtc_base/ptr_util.h" // Adding 'nogncheck' to disable the gn include headers check to support modular // WebRTC build targets. // TODO(zhihuang): This wouldn't be necessary if the interface and @@ -260,10 +261,9 @@ RTC_FROM_HERE, rtc::Bind(&cricket::PortAllocator::SetNetworkIgnoreMask, allocator.get(), options_.network_ignore_mask)); - std::unique_ptr<RtcEventLog> event_log(new RtcEventLogNullImpl()); - if (event_log_factory_) { - event_log = event_log_factory_->CreateRtcEventLog(); - } + std::unique_ptr<RtcEventLog> event_log = + event_log_factory_ ? event_log_factory_->CreateRtcEventLog() + : rtc::MakeUnique<RtcEventLogNullImpl>(); std::unique_ptr<Call> call = worker_thread_->Invoke<std::unique_ptr<Call>>( RTC_FROM_HERE,