)]}'
{
  "commit": "3dc41069ef8189e4dec4f76ff3ed0f8d11e865cd",
  "tree": "4d7f88e52ac804a1a626a3b329dcfb5335a2337b",
  "parents": [
    "9df3cf3e8c0ae907c1e545eef3aa3f79afd779a8"
  ],
  "author": {
    "name": "Patrik Höglund",
    "email": "phoglund@webrtc.org",
    "time": "Wed Apr 11 11:13:57 2018"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Apr 11 11:15:08 2018"
  },
  "message": "Revert \"Add thread checker to PortAllocator and its subclasses and fix a bug\"\n\nThis reverts commit fc43d11717e16dd427ac84fee614e5511e43cefd.\n\nReason for revert: Crashes downstream tests\n\nOriginal change\u0027s description:\n\u003e Add thread checker to PortAllocator and its subclasses and fix a bug\n\u003e causing memory contention by threads.\n\u003e \n\u003e PortAllocator and its subclasses assume all of their methods except the\n\u003e constructor must be called on the same thread (the network thread in\n\u003e practice). This CL adds a thread checker to PortAllocator and its\n\u003e subclasses for thread safety, and fixes bugs of invoking some of their\n\u003e methods in PeerConnection on the signaling thread.\n\u003e \n\u003e Bug: webrtc:9112\n\u003e Change-Id: I33ba9bae72ec09a45ec70435962f3f25cd31583c\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/66945\n\u003e Commit-Queue: Qingsi Wang \u003cqingsi@google.com\u003e\n\u003e Reviewed-by: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#22814}\n\nTBR\u003ddeadbeef@webrtc.org,pthatcher@google.com,pthatcher@webrtc.org,qingsi@google.com,honghaiz@webrtc.org\n\nChange-Id: I2db6561d5d6366d38caa58c3e719d0d48eda70c2\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: webrtc:9112\nReviewed-on: https://webrtc-review.googlesource.com/69200\nReviewed-by: Patrik Höglund \u003cphoglund@webrtc.org\u003e\nCommit-Queue: Patrik Höglund \u003cphoglund@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#22818}",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "76df3df693b5aa121eb8e7fcdd3157df4056afea",
      "old_mode": 33188,
      "old_path": "p2p/base/fakeportallocator.h",
      "new_id": "3f0a1d4f8c5b7ae5f7158e7ab23451b90c3fa10b",
      "new_mode": 33188,
      "new_path": "p2p/base/fakeportallocator.h"
    },
    {
      "type": "modify",
      "old_id": "9d9df530eb01fc52d0ca4b3e32538589363d57ed",
      "old_mode": 33188,
      "old_path": "p2p/base/p2ptransportchannel_unittest.cc",
      "new_id": "2b0efacc2df98b05a83c3280effef15a9f20061c",
      "new_mode": 33188,
      "new_path": "p2p/base/p2ptransportchannel_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "d9383610d629f4d01fb21df612dff8d631e6a4c6",
      "old_mode": 33188,
      "old_path": "p2p/base/portallocator.cc",
      "new_id": "e766fa732c415da1ba174ed0094aab2bfcbfe9e5",
      "new_mode": 33188,
      "new_path": "p2p/base/portallocator.cc"
    },
    {
      "type": "modify",
      "old_id": "f985b2171b4b43dcf1dc883a7e344f9447322438",
      "old_mode": 33188,
      "old_path": "p2p/base/portallocator.h",
      "new_id": "95052c2db1f829cefacfe598a94d32e554dc9c05",
      "new_mode": 33188,
      "new_path": "p2p/base/portallocator.h"
    },
    {
      "type": "modify",
      "old_id": "a25a937ddb7307e2cdc9cafcf90ad194e7bac372",
      "old_mode": 33188,
      "old_path": "p2p/client/basicportallocator.cc",
      "new_id": "1b3947b6cfc3ca644768b9ba19e1c06c77e5827b",
      "new_mode": 33188,
      "new_path": "p2p/client/basicportallocator.cc"
    },
    {
      "type": "modify",
      "old_id": "1822b7da2f0aa55d1e8eac654eb9cf49e5f8c2f1",
      "old_mode": 33188,
      "old_path": "p2p/client/basicportallocator.h",
      "new_id": "fb74ba5d74f3f6d137d853e513d55ed633c0bbf5",
      "new_mode": 33188,
      "new_path": "p2p/client/basicportallocator.h"
    },
    {
      "type": "modify",
      "old_id": "6ed13b57984f07c54146e03b45598b836d843c8c",
      "old_mode": 33188,
      "old_path": "p2p/client/basicportallocator_unittest.cc",
      "new_id": "f39e61e3ee9c893c3162d0b9c8ea749976add6ef",
      "new_mode": 33188,
      "new_path": "p2p/client/basicportallocator_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "90242a87a79ef0b8531534920b1b245bc182eeee",
      "old_mode": 33188,
      "old_path": "pc/peerconnection.cc",
      "new_id": "1f63874e3bd89fd36c01cd7c900495e2507d339c",
      "new_mode": 33188,
      "new_path": "pc/peerconnection.cc"
    },
    {
      "type": "modify",
      "old_id": "401ffd49b46d525c857cc8e64512980eaf720be2",
      "old_mode": 33188,
      "old_path": "pc/peerconnection.h",
      "new_id": "fa46a4e151f665024fe376d3b1ce5dddadd45ed3",
      "new_mode": 33188,
      "new_path": "pc/peerconnection.h"
    },
    {
      "type": "modify",
      "old_id": "f05ece4efb8d1847e8653f44761409ea43073aef",
      "old_mode": 33188,
      "old_path": "pc/peerconnection_integrationtest.cc",
      "new_id": "f7ac830a65bf5c69728b26a317eb1deb93a4599d",
      "new_mode": 33188,
      "new_path": "pc/peerconnection_integrationtest.cc"
    },
    {
      "type": "modify",
      "old_id": "acb0dbdd04f641a39355e3865ee08198863bd4a4",
      "old_mode": 33188,
      "old_path": "pc/peerconnectioninterface_unittest.cc",
      "new_id": "8ee39c945b79266cba7695bce24175b6892aa26d",
      "new_mode": 33188,
      "new_path": "pc/peerconnectioninterface_unittest.cc"
    }
  ]
}