commit 402ceffff13f3ab98c404c3dcef2a2eab920ec1f
author Victor Boivie <boivie@webrtc.org> Wed May 19 12:26:22 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 19 13:22:43 2021
tree f5529bffc6e58cb7531a57fe07ff4aa173bbb48b
parent 3a45d32d4e6982fbfb3927e43cf607af2d826a4b

sctp: Reduce logging level for common calls

Reduced the level so that the library can be run with INFO level without
a lot of spam. VERBOSE is still reserved for frequent logs.

Also, using WARNING for logs that are not fatal and which can easily
be triggered by the user.

Bug: webrtc:12614
Change-Id: If09c302b2b5bfc002471f86a8aeb74ba1172c705
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219465
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34054}

media/sctp/dcsctp_transport.cc

diff --git a/media/sctp/dcsctp_transport.cc b/media/sctp/dcsctp_transport.cc
index f0ec69a..0a6cb33 100644
--- a/media/sctp/dcsctp_transport.cc
+++ b/media/sctp/dcsctp_transport.cc
@@ -237,11 +237,11 @@
 
   auto max_message_size = socket_->options().max_message_size;
   if (max_message_size > 0 && payload.size() > max_message_size) {
-    RTC_LOG(LS_ERROR) << debug_name_
-                      << "->SendData(...): "
-                         "Trying to send packet bigger "
-                         "than the max message size: "
-                      << payload.size() << " vs max of " << max_message_size;
+    RTC_LOG(LS_WARNING) << debug_name_
+                        << "->SendData(...): "
+                           "Trying to send packet bigger "
+                           "than the max message size: "
+                        << payload.size() << " vs max of " << max_message_size;
     *result = cricket::SDR_ERROR;
     return false;
   }
@@ -348,9 +348,9 @@
                              data.size(), rtc::PacketOptions(), 0);
 
   if (result < 0) {
-    RTC_LOG(LS_ERROR) << debug_name_ << "->SendPacket(length=" << data.size()
-                      << ") failed with error: " << transport_->GetError()
-                      << ".";
+    RTC_LOG(LS_WARNING) << debug_name_ << "->SendPacket(length=" << data.size()
+                        << ") failed with error: " << transport_->GetError()
+                        << ".";
   }
 }
 
@@ -375,10 +375,10 @@
 
 void DcSctpTransport::OnMessageReceived(dcsctp::DcSctpMessage message) {
   RTC_DCHECK_RUN_ON(network_thread_);
-  RTC_LOG(LS_INFO) << debug_name_
-                   << "->OnMessageReceived(sid=" << message.stream_id().value()
-                   << ", ppid=" << message.ppid().value()
-                   << ", length=" << message.payload().size() << ").";
+  RTC_LOG(LS_VERBOSE) << debug_name_ << "->OnMessageReceived(sid="
+                      << message.stream_id().value()
+                      << ", ppid=" << message.ppid().value()
+                      << ", length=" << message.payload().size() << ").";
   cricket::ReceiveDataParams receive_data_params;
   receive_data_params.sid = message.stream_id().value();
   auto type = ToDataMessageType(message.ppid());
@@ -435,7 +435,7 @@
     absl::string_view reason) {
   // TODO(orphis): Need a test to check for correct behavior
   for (auto& stream_id : outgoing_streams) {
-    RTC_LOG(LS_ERROR)
+    RTC_LOG(LS_WARNING)
         << debug_name_
         << "->OnStreamsResetFailed(...): Outgoing stream reset failed"
         << ", sid=" << stream_id.value() << ", reason: " << reason << ".";
@@ -490,8 +490,9 @@
   RTC_DCHECK_RUN_ON(network_thread_);
   RTC_DCHECK_EQ(transport_, transport);
 
-  RTC_LOG(LS_INFO) << debug_name_ << "->OnTransportWritableState(), writable="
-                   << transport->writable();
+  RTC_LOG(LS_VERBOSE) << debug_name_
+                      << "->OnTransportWritableState(), writable="
+                      << transport->writable();
 
   MaybeConnectSocket();
 }