| commit | 413ee9a010eca70712a6935c68b815201bee1270 | [log] [tgz] |
|---|---|---|
| author | eladalon <eladalon@webrtc.org> | Tue Aug 22 11:02:52 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Aug 22 11:02:52 2017 |
| tree | 361132b89111bd166a50fc3f1ad0dffa73d2ecd9 | |
| parent | 2a596549ca6fba655727dbf24505c75711920340 [diff] |
Use SingleThreadedTaskQueue in DirectTransport DirectTransport has so far used its own thread, which led to a different threading-model for in the unit-tests than is used in actual WebRTC. Because of that, some critical-sections that weren't truly necessary in WebRTC could not be replaced with thread-checks, because those checks failed in unit-tests. This CL introduces SingleThreadedTaskQueue - a TaskQueue which guarantees to run all of its tasks on the same thread (rtc::TaskQueue doesn't guarantee that on Mac) - and uses that for DirectTransport. CLs based on top of this will uncomment thread-checks which had to be commented out before, and remove unnecessary critical-sections. Future work would probably replace the thread-checkers by more sophisticated serialized-access checks, allowing us to move from the SingleThreadedTaskQueue to a normal TaskQueue. Related implementation notes: * This CL has made DirectTransport::StopSending() superfluous, and so it was deleted. BUG=webrtc:8113, webrtc:7405, webrtc:8056, webrtc:8116 Review-Url: https://codereview.webrtc.org/2998923002 Cr-Commit-Position: refs/heads/master@{#19445}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.