)]}'
{
  "commit": "47faf322872f2ae9535470eb8fb3ce8bb59dad4a",
  "tree": "e95525e519740af85f4abe1ba01ba4ccfd7014ab",
  "parents": [
    "5f3b3db1056aa40e8c0a6a46337b67e6db29b6dd"
  ],
  "author": {
    "name": "Arthur Sonzogni",
    "email": "arthursonzogni@chromium.org",
    "time": "Tue Aug 22 09:55:36 2023"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Aug 22 11:32:06 2023"
  },
  "message": "Add rtc_common_public_deps\n\nWhen built for chromium, some webrtc implementations are overridden and\nare implemented by chrome\u0027s \"//base\". For instance webrtc::Location is\nimplemented by base::Location. So far so good, the affected targets are\ncorrectly defined in GN to depend on base.\n\nThe problem: Most targets in webrtc do not declare correctly their\npublic_deps. When a public header of a target includes one from its\ndependency, the dependency must be a public_deps. The public_deps\ninstruct GN to forward the capability to use code from the dependency\ntoward the dependent.\n\nUnfortunately, it is not possible to fix the `public_deps` in webrtc,\nbecause its is disallowed via a presubmit. See:\nhttps://webrtc-review.googlesource.com/c/src/+/30262\n\nWebRTC developers decided not to use `public_deps`, because GN config\nare \"translated\" toward different kind of downstream build system who do\nnot really support the `public` dependencies concept. Instead WebRTC is\nusing some \"common\" configuration applied to all of its targets.\n\nThis patch add `rtc_common_public_deps` argument, to let embedders\nadd the dependencies WebRTC depends on.\n\nBug: chromium:1467773\nChange-Id: I7de43372414a09886fcb07905451e6339c8ecc64\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/316660\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#40595}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ca5a869a40028e2380badd7acbbf9b5352c10da8",
      "old_mode": 33188,
      "old_path": "api/BUILD.gn",
      "new_id": "b2a7947c772dbe3e65465f3ee556669ed70c2a9d",
      "new_mode": 33188,
      "new_path": "api/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "1420aa638559037b9bc1e7198fe498e6c96b41d7",
      "old_mode": 33188,
      "old_path": "modules/audio_coding/BUILD.gn",
      "new_id": "8f5019b4c2774bbe52352d22bd92b22c11222a9c",
      "new_mode": 33188,
      "new_path": "modules/audio_coding/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "162981c427a02f035aeaf5f85e68b84e486df681",
      "old_mode": 33188,
      "old_path": "modules/audio_device/BUILD.gn",
      "new_id": "f1ab09d154ba16b7f9c6853c1154af1e85ba9ea4",
      "new_mode": 33188,
      "new_path": "modules/audio_device/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "89b934e596474393fe2de7e070180404f18bbf7a",
      "old_mode": 33188,
      "old_path": "test/BUILD.gn",
      "new_id": "e8d4fdbc0482355d98353a8b714406f457e20c95",
      "new_mode": 33188,
      "new_path": "test/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "91db36d00360fa6860daa8f5b55ede18ac6f1601",
      "old_mode": 33188,
      "old_path": "webrtc.gni",
      "new_id": "5a1c43c88883fb512f2332461a00d11c3d977446",
      "new_mode": 33188,
      "new_path": "webrtc.gni"
    }
  ]
}