commit | 48e7065ac6a34badd04d8f9d5dab64305e5b7b31 | [log] [tgz] |
---|---|---|
author | Elad Alon <eladalon@webrtc.org> | Tue Feb 12 10:42:40 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 27 14:33:03 2019 |
tree | 8e160de5d149772b7b4d7f4b89b9354ee3276e14 | |
parent | 1a7a4afd139e5b0ad91df5d7d2dae4a080fd6b9a [diff] |
Remove default IDs for RTP extensions from rtp_parameters.h One-byte RTP extensions may only have IDs in the range 1-14. For higher IDs, the two-byte format must be used. If default IDs are set for all extensions, once 15 extensions are defined by the code, some extensions will have IDs greater than 14. This will happen even if only one extension actually ends up being offered, so long as it's that unfortunate RTP extension. It's better to dynamically assign the IDs to those extensions we actually offer. The code that assigns the IDs is currently distributed ( WebRtcVoiceEngine::GetCapabilities() and WebRtcVideoEngine::GetCapabilities()), and without a bigger refactoring effort would produce some ID collisions and mismatches. Those are already handled by MergeRtpHdrExts(), so so that should not be a problem. Bug: webrtc:10288 Change-Id: I087f1ed5baa9fd61fd5556f1d82f540304ec6b93 Reviewed-on: https://webrtc-review.googlesource.com/c/122480 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26876}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.