commit 4f642c11f870287f8856da32ad401a4cf3705829
author Erik Språng <sprang@webrtc.org> Tue Feb 14 15:50:00 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 14 17:35:19 2023
tree a69980c93f896d53a736d499a19a0f738454ab97
parent 2bee5dd4e3118fe730fdda88e62d599ca2e28099

Remove WebRTC-TaskQueuePacer trial.

Removes the last unused field trial parameters, the legacy pacer code
was removed some time ago so the main flag feature has been a noop
since then.

Bug: None
Change-Id: I5266d54fccb4c5fde05a6895072cd76cd5f7fbd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293349
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39310}

call/rtp_transport_controller_send.cc

diff --git a/call/rtp_transport_controller_send.cc b/call/rtp_transport_controller_send.cc
index 940dff7..0b467b7 100644
--- a/call/rtp_transport_controller_send.cc
+++ b/call/rtp_transport_controller_send.cc
@@ -70,14 +70,6 @@
 }
 }  // namespace
 
-RtpTransportControllerSend::PacerSettings::PacerSettings(
-    const FieldTrialsView& trials)
-    : holdback_window("holdback_window", TimeDelta::Millis(5)),
-      holdback_packets("holdback_packets", 3) {
-  ParseFieldTrial({&holdback_window, &holdback_packets},
-                  trials.Lookup("WebRTC-TaskQueuePacer"));
-}
-
 RtpTransportControllerSend::RtpTransportControllerSend(
     Clock* clock,
     const RtpTransportConfig& config)
@@ -86,13 +78,12 @@
       task_queue_factory_(config.task_queue_factory),
       bitrate_configurator_(config.bitrate_config),
       pacer_started_(false),
-      pacer_settings_(*config.trials),
       pacer_(clock,
              &packet_router_,
              *config.trials,
              config.task_queue_factory,
-             pacer_settings_.holdback_window.Get(),
-             pacer_settings_.holdback_packets.Get(),
+             TimeDelta::Millis(5),
+             3,
              config.pacer_burst_interval),
       observer_(nullptr),
       controller_factory_override_(config.network_controller_factory),