)]}'
{
  "commit": "5411b174c81c37f809a95913c1304dfcccfcdcfd",
  "tree": "025c6efa117e99b4b0b162476693421943551129",
  "parents": [
    "c0a4316825a8a5ebffa60713e32660f4c7ffb336"
  ],
  "author": {
    "name": "Tomas Gunnarsson",
    "email": "tommi@webrtc.org",
    "time": "Mon Jan 24 07:45:26 2022"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Jan 24 08:50:30 2022"
  },
  "message": "Add a channel factory interface.\n\nThe interface is implemented by the ChannelManager and contains methods\nto create and destroy media channel objects as used by a transceiver.\n\nThis will subsequently allow us to delete the channel objects from\nthe transceiver class where ownership really lies rather than from\nthe outside - which is currently required by some tests that keep\nchannel objects on the stack. We\u0027ll furthermore be able to do the\ndestruction asynchronously without additional Invoke()s as we do now\nwhich will remove an Invoke when making sdp changes.\n\nWith introducing the interface, the following simplifications were made:\n* ChannelManager constructed on the signaling thread.\n  Before, there was an Invoke in the context class, which existed\n  for the purposes of calling MediaEngine::Init() (which in turn is\n  only needed for the VoiceEngine). This Invoke has now been moved\n  into the CM (more tbd).\n* The CM now has a pointer to the signaling thread (since that\u0027s the\n  construction thread). That allows us to remove the signaling thread\n  parameter from the CreateFooChannel methods.\n* The ssrc_generator (UniqueRandomIdGenerator) instance for SSRCs moved\n  from SdpOfferAnswerHandler to the CM, as it\u0027s always used in\n  combination with the CM. This simplifies the CreateFooChannel methods\n  as well as a couple of other classes that have a CM dependency.\n* Removed DestroyFooChannel related code from SdpOfferAnswerHandler since\n  the channel type detail can be taken care of by the CM.\n\nBug: webrtc:11992, webrtc:13540\nChange-Id: I04938a803734de8489ba31e6212d9eaecc244126\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/247904\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCommit-Queue: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#35766}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "536df8e22bc277cfd8ace028ac3528f404d7fd24",
      "old_mode": 33188,
      "old_path": "media/engine/webrtc_voice_engine.cc",
      "new_id": "99f3898e685e2960ef50f254008e298c8bb06409",
      "new_mode": 33188,
      "new_path": "media/engine/webrtc_voice_engine.cc"
    },
    {
      "type": "modify",
      "old_id": "dac0cbcf68a3bd801a92c0e4c7208049ec1f5544",
      "old_mode": 33188,
      "old_path": "pc/channel.cc",
      "new_id": "5210ae42374d1b7c062938255a175ed3b0ff085e",
      "new_mode": 33188,
      "new_path": "pc/channel.cc"
    },
    {
      "type": "modify",
      "old_id": "fd5495c152de64c49b9929a80a9dd987f69180b1",
      "old_mode": 33188,
      "old_path": "pc/channel.h",
      "new_id": "829d29eefa49ca2646a02ded260fbde8e88f5df3",
      "new_mode": 33188,
      "new_path": "pc/channel.h"
    },
    {
      "type": "modify",
      "old_id": "6185b69e6af889a792cef7cb977390a7ba80f4a5",
      "old_mode": 33188,
      "old_path": "pc/channel_interface.h",
      "new_id": "6033046b920b45b58c2387b63ff3cabe524bb074",
      "new_mode": 33188,
      "new_path": "pc/channel_interface.h"
    },
    {
      "type": "modify",
      "old_id": "304283eca4ae7e983cd5dc08a6ed580da46ea1ef",
      "old_mode": 33188,
      "old_path": "pc/channel_manager.cc",
      "new_id": "b583b94e3dd5f843e25eccb2229cb2dbe0183b14",
      "new_mode": 33188,
      "new_path": "pc/channel_manager.cc"
    },
    {
      "type": "modify",
      "old_id": "0952099e824e61ade8a2b06202c38572af0d5a32",
      "old_mode": 33188,
      "old_path": "pc/channel_manager.h",
      "new_id": "9e4e1bf1319b8735cb38c543fecf75dee5b6e2f2",
      "new_mode": 33188,
      "new_path": "pc/channel_manager.h"
    },
    {
      "type": "modify",
      "old_id": "80f30c1c71f9283fccefcaafc8dc402e2b47286b",
      "old_mode": 33188,
      "old_path": "pc/channel_manager_unittest.cc",
      "new_id": "765e8e144da502edbae4546c0f5a067afc55486f",
      "new_mode": 33188,
      "new_path": "pc/channel_manager_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6c6da4e476949376e7e00343db3fc0be16b93b50",
      "old_mode": 33188,
      "old_path": "pc/connection_context.cc",
      "new_id": "558702a72e15bf3b4eff360f1878fe7908c8c42b",
      "new_mode": 33188,
      "new_path": "pc/connection_context.cc"
    },
    {
      "type": "modify",
      "old_id": "ed292cf5dee06fb4099d81a58e4bc17f5da849c0",
      "old_mode": 33188,
      "old_path": "pc/media_session.cc",
      "new_id": "637dbec73b9a0dd3a35682d32c4ad8e9c6e6902d",
      "new_mode": 33188,
      "new_path": "pc/media_session.cc"
    },
    {
      "type": "modify",
      "old_id": "bb97f42b2778d36bceac8e2ce054b5cfb3832fba",
      "old_mode": 33188,
      "old_path": "pc/media_session.h",
      "new_id": "aa24f015de30fdbc88a1b87db00f57b11631f566",
      "new_mode": 33188,
      "new_path": "pc/media_session.h"
    },
    {
      "type": "modify",
      "old_id": "3c6402cead82e5cc528125b077f76d9b39d864d7",
      "old_mode": 33188,
      "old_path": "pc/peer_connection.cc",
      "new_id": "3e1a09bb500844c0c22efdea4e72d293f13f8434",
      "new_mode": 33188,
      "new_path": "pc/peer_connection.cc"
    },
    {
      "type": "modify",
      "old_id": "59f43c7d9a5e04f584e6aab60d58d710b11f3759",
      "old_mode": 33188,
      "old_path": "pc/peer_connection.h",
      "new_id": "20d946dfdcbc7f720c0359d60b091105f8b9d3ca",
      "new_mode": 33188,
      "new_path": "pc/peer_connection.h"
    },
    {
      "type": "modify",
      "old_id": "49a79a2556b4f5a1d05189f545de2425280c841c",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_ice_unittest.cc",
      "new_id": "59f5b5620d2e93d2ea378befaf2c5d18f051c5fb",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_ice_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6ebbe3deba2651a774a1b62b687990756f6773e2",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector.cc",
      "new_id": "ca1671a39e702a71eca67a374fbf209277ea1f3b",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector.cc"
    },
    {
      "type": "modify",
      "old_id": "612762248253d9700384fe19182f817ce8cfe6b0",
      "old_mode": 33188,
      "old_path": "pc/rtp_sender_receiver_unittest.cc",
      "new_id": "2c6bc7b71a1e5e30609f382fee0b4cc30f03512e",
      "new_mode": 33188,
      "new_path": "pc/rtp_sender_receiver_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "e152d76bf5fa394962fa689c9a75682a70b77441",
      "old_mode": 33188,
      "old_path": "pc/rtp_transceiver.cc",
      "new_id": "becf8f2cca65b283dbbf7deb3b960e3d61d0d01a",
      "new_mode": 33188,
      "new_path": "pc/rtp_transceiver.cc"
    },
    {
      "type": "modify",
      "old_id": "a1a2a197fb6b2b9390fb30cad2fa77499dcf0156",
      "old_mode": 33188,
      "old_path": "pc/rtp_transceiver_unittest.cc",
      "new_id": "0122c0d64dd787581c7d8cc90a24c08d54c5184a",
      "new_mode": 33188,
      "new_path": "pc/rtp_transceiver_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ea1c4c4d23c700c91dbf61d471afad67ffcb7df3",
      "old_mode": 33188,
      "old_path": "pc/sdp_offer_answer.cc",
      "new_id": "f80e7191da65564e5a04708bfeef864212228aa0",
      "new_mode": 33188,
      "new_path": "pc/sdp_offer_answer.cc"
    },
    {
      "type": "modify",
      "old_id": "7349999807810ce43a6fc5b36cc19d0e99a64cc7",
      "old_mode": 33188,
      "old_path": "pc/sdp_offer_answer.h",
      "new_id": "e7851d8d6cdc192201fa6dbf4778cab3649f3d36",
      "new_mode": 33188,
      "new_path": "pc/sdp_offer_answer.h"
    },
    {
      "type": "modify",
      "old_id": "c2d44bb5f41199e66a7a9b57f5179d9e15b5975c",
      "old_mode": 33188,
      "old_path": "pc/stats_collector.cc",
      "new_id": "493c26cfbdccc8f32aabe1c9340335f61bedd482",
      "new_mode": 33188,
      "new_path": "pc/stats_collector.cc"
    },
    {
      "type": "modify",
      "old_id": "de59ebd75b8e3e2dde626b6c72a0f117cf543440",
      "old_mode": 33188,
      "old_path": "pc/test/mock_channel_interface.h",
      "new_id": "844a36e2d03fd737126b1d9c5facfd9abb601c3c",
      "new_mode": 33188,
      "new_path": "pc/test/mock_channel_interface.h"
    },
    {
      "type": "modify",
      "old_id": "ac20308df967345ff5b2fe157bdedf2a1182af85",
      "old_mode": 33188,
      "old_path": "pc/webrtc_session_description_factory.cc",
      "new_id": "36130758a332891ea5f9df9cb8f8dc7bfa8f81bd",
      "new_mode": 33188,
      "new_path": "pc/webrtc_session_description_factory.cc"
    },
    {
      "type": "modify",
      "old_id": "efa208ff78641eeebb84587d7e9f354c83d0a441",
      "old_mode": 33188,
      "old_path": "pc/webrtc_session_description_factory.h",
      "new_id": "6a6e8efa51950be889e3eb7b05b9a6d56fa6df87",
      "new_mode": 33188,
      "new_path": "pc/webrtc_session_description_factory.h"
    }
  ]
}