commit 55a59337c87614f49c87b846ecf3393b2241d5a6
author yazdan0a <ayp@meta.com> Tue Sep 03 02:15:39 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 04 07:19:15 2024
tree be9b383dabe392a5f842ece0fba89ddde93ac7ac
parent 45065a749da409a4fa128907139aedfee35d4a19

Minor format to extrapolate local time

- Removing unnecessary else {} blocks for better readability.
- Consistent naming of: timestamp_diff with explicit typecast.

BUG=None

Change-Id: I35161ffed245737c789336316f0cfb6821b12349
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361060
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42939}

modules/video_coding/timing/timestamp_extrapolator.cc

diff --git a/modules/video_coding/timing/timestamp_extrapolator.cc b/modules/video_coding/timing/timestamp_extrapolator.cc
index e87a46a..1560503 100644
--- a/modules/video_coding/timing/timestamp_extrapolator.cc
+++ b/modules/video_coding/timing/timestamp_extrapolator.cc
@@ -129,7 +129,8 @@
 
   if (!first_unwrapped_timestamp_) {
     return std::nullopt;
-  } else if (packet_count_ < kStartUpFilterDelayInPackets) {
+  }
+  if (packet_count_ < kStartUpFilterDelayInPackets) {
     constexpr double kRtpTicksPerMs = 90;
     TimeDelta diff = TimeDelta::Millis(
         (unwrapped_ts90khz - *prev_unwrapped_timestamp_) / kRtpTicksPerMs);
@@ -139,19 +140,20 @@
       return std::nullopt;
     }
     return prev_ + diff;
-  } else if (w_[0] < 1e-3) {
-    return start_;
-  } else {
-    double timestampDiff = unwrapped_ts90khz - *first_unwrapped_timestamp_;
-    TimeDelta diff = TimeDelta::Millis(
-        static_cast<int64_t>((timestampDiff - w_[1]) / w_[0] + 0.5));
-    if (start_.us() + diff.us() < 0) {
-      // Prevent the construction of a negative Timestamp.
-      // This scenario can occur when the RTP timestamp wraps around.
-      return std::nullopt;
-    }
-    return start_ + diff;
   }
+  if (w_[0] < 1e-3) {
+    return start_;
+  }
+  double timestamp_diff =
+      static_cast<double>(unwrapped_ts90khz - *first_unwrapped_timestamp_);
+  TimeDelta diff = TimeDelta::Millis(
+      static_cast<int64_t>((timestamp_diff - w_[1]) / w_[0] + 0.5));
+  if (start_.us() + diff.us() < 0) {
+    // Prevent the construction of a negative Timestamp.
+    // This scenario can occur when the RTP timestamp wraps around.
+    return std::nullopt;
+  }
+  return start_ + diff;
 }
 
 bool TimestampExtrapolator::DelayChangeDetection(double error) {