)]}'
{
  "commit": "581df618feecc493042fa66ee6ed9fdb0e5bc65a",
  "tree": "3199704706b934ec835a7d5adf79a4f98532813f",
  "parents": [
    "884e49f9d69968c124f082999a57bab4019230de"
  ],
  "author": {
    "name": "Patrik Höglund",
    "email": "phoglund@webrtc.org",
    "time": "Mon Oct 02 09:12:39 2017"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Oct 02 09:12:51 2017"
  },
  "message": "Revert \"Reland \"Clean up libjingle API dependencies.\"\"\n\nThis reverts commit 5117b047875970cf61f2403b590c44c37bfa8272.\n\nReason for revert: Still breaks downstream projects that include too much stuff.\n\nOriginal change\u0027s description:\n\u003e Reland \"Clean up libjingle API dependencies.\"\n\u003e \n\u003e This is a reland of 57fb3154b5411934b80051ad827db4e54d00f381\n\u003e Original change\u0027s description:\n\u003e \u003e Clean up libjingle API dependencies.\n\u003e \u003e \n\u003e \u003e This CL moves candidate.h into the public API, since it has\n\u003e \u003e been implicitly included before.\n\u003e \u003e \n\u003e \u003e This is a straightforward way of solving the circular\n\u003e \u003e dependencies involving that file. For instance,\n\u003e \u003e libjingle_peerconnection_api includes candidate.h from\n\u003e \u003e jsepicecandidate.h, but _api can\u0027t depend on rtc_p2p, which\n\u003e \u003e depends on _api. In fact, _api can\u0027t depend on much at all\n\u003e \u003e since it\u0027s a very high level abstraction; instead, things\n\u003e \u003e should depend on it.\n\u003e \u003e \n\u003e \u003e Furthermore, we have the case where deprecated headers\n\u003e \u003e include headers in internal modules. I just have to turn\n\u003e \u003e off include checking for those, but that\u0027s not a big deal.\n\u003e \u003e \n\u003e \u003e This CL punts the problem of callfactoryinterface.h being\n\u003e \u003e implicitly included, and pulling in most of the call\n\u003e \u003e module with it. This should be addressed in a follow-up\n\u003e \u003e CL.\n\u003e \u003e \n\u003e \u003e Bug: webrtc:7504\n\u003e \u003e Change-Id: I1b1729408158418333ccdf702bf529386090f0d7\n\u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/2020\n\u003e \u003e Commit-Queue: Patrik Höglund \u003cphoglund@webrtc.org\u003e\n\u003e \u003e Reviewed-by: Fredrik Solenberg \u003csolenberg@webrtc.org\u003e\n\u003e \u003e Reviewed-by: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#20034}\n\u003e \n\u003e Bug: webrtc:7504\n\u003e Change-Id: I74aeeff678a4ce6482d2f402493ae13e698f1390\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/4703\n\u003e Commit-Queue: Patrik Höglund \u003cphoglund@webrtc.org\u003e\n\u003e Reviewed-by: Fredrik Solenberg \u003csolenberg@webrtc.org\u003e\n\u003e Reviewed-by: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\n\u003e Reviewed-by: Patrik Höglund \u003cphoglund@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#20062}\n\nTBR\u003dphoglund@webrtc.org,deadbeef@webrtc.org,solenberg@webrtc.org\n\nChange-Id: I19068df5f3ee8145c5ff13c86a42b6860e9cc834\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: webrtc:7504\nReviewed-on: https://webrtc-review.googlesource.com/5460\nReviewed-by: Patrik Höglund \u003cphoglund@webrtc.org\u003e\nCommit-Queue: Patrik Höglund \u003cphoglund@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#20065}",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6c0c6fd6d707cd6d741e51d87a3b6cab80a6a22a",
      "old_mode": 33188,
      "old_path": "api/BUILD.gn",
      "new_id": "86a63e4dee852d325a5b00ac4ed23acea628c4d7",
      "new_mode": 33188,
      "new_path": "api/BUILD.gn"
    },
    {
      "type": "delete",
      "old_id": "78b20827e505e9437f5efaf802d5ad37a99e847d",
      "old_mode": 33188,
      "old_path": "api/candidate.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "dae6121eade1ec308b1cae9b46c10781f4727795",
      "old_mode": 33188,
      "old_path": "api/jsepicecandidate.h",
      "new_id": "2965e866afbdf1fa74a76435012a26cf9096c192",
      "new_mode": 33188,
      "new_path": "api/jsepicecandidate.h"
    },
    {
      "type": "modify",
      "old_id": "6b115ee2e9034a77bb9416fd0b89f95cde2aed14",
      "old_mode": 33188,
      "old_path": "api/jsepsessiondescription.h",
      "new_id": "21adfeefc0ec614d8c974f0f82ffcf67dc80bf8d",
      "new_mode": 33188,
      "new_path": "api/jsepsessiondescription.h"
    },
    {
      "type": "modify",
      "old_id": "fa074a0533fd11937ee21990dffb9dc038e71ae2",
      "old_mode": 33188,
      "old_path": "api/mediastreaminterface.h",
      "new_id": "4e5fde18227a2331182c4eb8faa0309fa98d967d",
      "new_mode": 33188,
      "new_path": "api/mediastreaminterface.h"
    },
    {
      "type": "modify",
      "old_id": "ea7d2c9ebb6550b9ab1c958ed85a6cbc91dee99b",
      "old_mode": 33188,
      "old_path": "p2p/base/candidate.h",
      "new_id": "87f24d22b824ca6f94015b20843845112f98918d",
      "new_mode": 33188,
      "new_path": "p2p/base/candidate.h"
    },
    {
      "type": "modify",
      "old_id": "c49ac479bcc34e5f13e4e301730364d89d79ad41",
      "old_mode": 33188,
      "old_path": "p2p/base/fakecandidatepair.h",
      "new_id": "17387892fb9fa2f7a873072373297aa20fdaaf4f",
      "new_mode": 33188,
      "new_path": "p2p/base/fakecandidatepair.h"
    },
    {
      "type": "modify",
      "old_id": "48f88062775cac9a13c9fe94576bc7e923792e05",
      "old_mode": 33188,
      "old_path": "p2p/base/icetransportinternal.h",
      "new_id": "5c67df9da676a81d5c2b723bd0af53842a146b19",
      "new_mode": 33188,
      "new_path": "p2p/base/icetransportinternal.h"
    },
    {
      "type": "modify",
      "old_id": "fbb6287ab2535aae516ab51174d3053f1b5b14c1",
      "old_mode": 33188,
      "old_path": "p2p/base/jseptransport.cc",
      "new_id": "74094fa07f04ef97a9a632011bb463541bd7f6e9",
      "new_mode": 33188,
      "new_path": "p2p/base/jseptransport.cc"
    },
    {
      "type": "modify",
      "old_id": "4cf9695eceafff9581ad7f303bc29ba7956c4d65",
      "old_mode": 33188,
      "old_path": "p2p/base/jseptransport.h",
      "new_id": "3486342a8414fcb3beec68b3aa165ba58dec2686",
      "new_mode": 33188,
      "new_path": "p2p/base/jseptransport.h"
    },
    {
      "type": "modify",
      "old_id": "c02bac7e66824074212709e94a9971d4a9807751",
      "old_mode": 33188,
      "old_path": "p2p/base/p2ptransportchannel.cc",
      "new_id": "44f8eee8efc85b480bbdb495a9f19c64cdab89b4",
      "new_mode": 33188,
      "new_path": "p2p/base/p2ptransportchannel.cc"
    },
    {
      "type": "modify",
      "old_id": "56ca57e11e8e45c3101287e19ed149281ed22524",
      "old_mode": 33188,
      "old_path": "p2p/base/p2ptransportchannel.h",
      "new_id": "b6a84bec94f7b16d64eac9a6380162743fa28abf",
      "new_mode": 33188,
      "new_path": "p2p/base/p2ptransportchannel.h"
    },
    {
      "type": "modify",
      "old_id": "61fd750691d3771d96e8e2882a5ed6a3221cbcc7",
      "old_mode": 33188,
      "old_path": "p2p/base/port.h",
      "new_id": "65f4d79f120f78f2e37c266373dece13d1cc0fb3",
      "new_mode": 33188,
      "new_path": "p2p/base/port.h"
    },
    {
      "type": "modify",
      "old_id": "3502423c125b8415a8767622a75c17b4ddbe31cb",
      "old_mode": 33188,
      "old_path": "p2p/base/transportinfo.h",
      "new_id": "3657b8dce50107d56565f50d394dafb3d6c149ac",
      "new_mode": 33188,
      "new_path": "p2p/base/transportinfo.h"
    },
    {
      "type": "modify",
      "old_id": "8e3c10f7c5da50887786827b92065cb6c06e9b06",
      "old_mode": 33188,
      "old_path": "pc/jsepsessiondescription_unittest.cc",
      "new_id": "781b59690a8a7e528ed92d8a1d513cc060d592e3",
      "new_mode": 33188,
      "new_path": "pc/jsepsessiondescription_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6ea7db0bb1957b476e415a2db7c70bd2d759c561",
      "old_mode": 33188,
      "old_path": "pc/rtcstatscollector.cc",
      "new_id": "161d224bc587242d34fb7025fd0a714483b16c08",
      "new_mode": 33188,
      "new_path": "pc/rtcstatscollector.cc"
    },
    {
      "type": "modify",
      "old_id": "be8dd8af705ee5b431a7e26fb4b2f9aaa00153d9",
      "old_mode": 33188,
      "old_path": "pc/transportcontroller.h",
      "new_id": "f8cfc0c2efdba0cff367da31f800645f8d7c2d7e",
      "new_mode": 33188,
      "new_path": "pc/transportcontroller.h"
    },
    {
      "type": "modify",
      "old_id": "47e429863e1e0e1bea08ece8b20a83a3b190b497",
      "old_mode": 33188,
      "old_path": "pc/webrtcsdp.cc",
      "new_id": "648d78c76bbeb6c8e62aefb5e0863ccb96bdda7a",
      "new_mode": 33188,
      "new_path": "pc/webrtcsdp.cc"
    },
    {
      "type": "modify",
      "old_id": "284c601b41997de313f69dd571ad42292a2fd488",
      "old_mode": 33188,
      "old_path": "pc/webrtcsession.h",
      "new_id": "44b64b8a36f3416565e091056e24723ccde4fc93",
      "new_mode": 33188,
      "new_path": "pc/webrtcsession.h"
    },
    {
      "type": "modify",
      "old_id": "354c320024ddd1ddc11d2173dab0f412e1ba8a42",
      "old_mode": 33188,
      "old_path": "rtc_base/BUILD.gn",
      "new_id": "93f8990ccc0a416cccfca0fcd6b421d18e939ac1",
      "new_mode": 33188,
      "new_path": "rtc_base/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "6bddf4626abe0f920583c73ee6ee22e44201eb48",
      "old_mode": 33188,
      "old_path": "rtc_base/network.h",
      "new_id": "b3b43d834fc08b50ec1a9f787b15253debdee675",
      "new_mode": 33188,
      "new_path": "rtc_base/network.h"
    },
    {
      "type": "delete",
      "old_id": "b4c8beaf319c6e6ae007b40c25c528fa54707ba6",
      "old_mode": 33188,
      "old_path": "rtc_base/network_constants.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "254b22575a5d81df2195823b4938c95d97f9207c",
      "old_mode": 33188,
      "old_path": "rtc_base/networkmonitor.h",
      "new_id": "d98b8031699f2b9d49376357c4895c6be87cc817",
      "new_mode": 33188,
      "new_path": "rtc_base/networkmonitor.h"
    }
  ]
}
