commit | d2303a2338106feab684860f1c133877b46bdd4f | [log] [tgz] |
---|---|---|
author | aleloi <aleloi@webrtc.org> | Fri May 26 12:13:18 2017 |
committer | Commit bot <commit-bot@chromium.org> | Fri May 26 12:13:18 2017 |
tree | f34be8d5e79b40fa0df53712600f089d9feb1236 | |
parent | 407e3afd379f55b8953ed9b07acf0162940237a5 [diff] |
Reland of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (patchset #1 id:1 of https://codereview.webrtc.org/2904893002/ ) Reason for revert: Revert the revert now that internal projects are updated. Original issue's description: > Revert of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (patchset #4 id:160001 of https://codereview.webrtc.org/2896813002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Activate 'offload debug dump recordings from audio thread to TaskQueue'. > > > > A low priority task queue is added to WebRTCVoiceEngine. The > > start/stop debug calls make file logging happen on the task queue. > > > > In a dependent CL (https://codereview.webrtc.org/2888303003), the task queue is moved to PeerConnectionFactory, > > so that it can be shared for low priority tasks between different > > subcomponents. It will require some changes to MediaEngine, > > CompositeMediaEngine, WebRTCVoiceEngine, and changes in internal > > projects. > > > > A task queue must be created and destroyed from the same thread. With > > this CL that will be the worker thread, which creates and destroys > > WebRTCVoiceEngine. With the dependent CL, it will probably change to > > the signaling thread. > > > > NOTRY=True # tests just passed > > > > BUG=webrtc:7404 > > > > Review-Url: https://codereview.webrtc.org/2896813002 > > Cr-Commit-Position: refs/heads/master@{#18252} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c61bf947b4ac31f3500858ffcae6fee39d799930 > > TBR=solenberg@webrtc.org,tommi@webrtc.org,perkj@webrtc.org,danilchap@webrtc.org,tommi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7404 > > Review-Url: https://codereview.webrtc.org/2904893002 > Cr-Commit-Position: refs/heads/master@{#18255} > Committed: https://chromium.googlesource.com/external/webrtc/+/be68b72cfad0686dcd892bba1368b199a7ee16ca TBR=solenberg@webrtc.org,tommi@webrtc.org,perkj@webrtc.org,danilchap@webrtc.org,tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7404 Review-Url: https://codereview.webrtc.org/2903153005 Cr-Commit-Position: refs/heads/master@{#18270}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.