commit 5d9b92b53daf4db78fd090be4e210e07f786120d
author noahric <noahric@chromium.org> Sat Oct 24 18:14:46 2015
committer Commit bot <commit-bot@chromium.org> Sat Oct 24 18:14:52 2015
tree 685c390ea21fe9364d2318a41f153232c1471b62
parent 2dd8bf825aba695aa0bda1707814d0646cff0a46

Update Bind to match its comments and always capture by value. Also update the generated count to 9 args.

The existing comment is wrong, and the test even ensures it: Bind will capture reference values by reference. That makes it hard to use with AsyncInvoker, because you can't safely Bind to a function that takes (const) reference params.

The new version of this code strips references in the bound object, so it captures by value, but can bind against functions that take const references, they'll just be references to the copy.

As the class comment implies, actual by-reference args should be passed as pointers or things that safely share (e.g. scoped_refptr) and not references directly. A new test case ensures the pointer reference works. The new code will also give a compiler error if you try to bind
to a non-const reference.

BUG=

Review URL: https://codereview.webrtc.org/1291543006

Cr-Commit-Position: refs/heads/master@{#10397}