commit 6cd6d8ecfd56c165635c127afcaeda7a303b1771
author Evan Shrubsole <eshr@webrtc.org> Fri Feb 11 14:30:26 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Feb 14 11:14:00 2022
tree 8983e9cb9db945c1901752384269639dc7e01801
parent 93348d89bc3cc77394b77915b5b2c0a033f401df

Introduce Sync-Decoding based on Metronome

Adds new class DecodeSynchronizer that will coalesce the decoding
of received streams on the metronome. This feature is experimental and
is backed by a field trial WebRTC-FrameBuffer3.

This experiment now has 3 arms to it,

"WebRTC-FrameBuffer3/arm:FrameBuffer2/": Default, uses old frame buffer.
"WebRTC-FrameBuffer3/arm:FrameBuffer3/": Uses new frame buffer.
"WebRTC-FrameBuffer3/arm:SyncDecoding/": Uses new frame buffer with
frame scheduled on the metronome.

The SyncDecoding arm will not work until it is wired up in the follow-up
CL.

This change also makes the following modifications,
* Adds FakeMetronome utilities for tests using a metronome.
* Makes FrameDecodeScheduler an interface. The default implementation is
TaskQueueFrameDecodeScheduler.
* FrameDecodeScheduler now has a Stop() method, which must be called
before destruction.


TBR=philipel@webrtc.org

Change-Id: I58a306bb883604b0be3eb2a04b3d07dbdf185c71
Bug: webrtc:13658
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250665
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Stefan Holmer <holmer@google.com>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35988}

video/frame_decode_timing_unittest.cc

diff --git a/video/frame_decode_timing_unittest.cc b/video/frame_decode_timing_unittest.cc
index ec77ed4..1932e85 100644
--- a/video/frame_decode_timing_unittest.cc
+++ b/video/frame_decode_timing_unittest.cc
@@ -81,10 +81,11 @@
 
   EXPECT_THAT(
       frame_decode_scheduler_.OnFrameBufferUpdated(90000, 180000, false),
-      Optional(AllOf(Field(&FrameDecodeTiming::FrameSchedule::max_decode_time,
-                           Eq(clock_.CurrentTime() + decode_delay)),
-                     Field(&FrameDecodeTiming::FrameSchedule::render_time,
-                           Eq(render_time)))));
+      Optional(
+          AllOf(Field(&FrameDecodeTiming::FrameSchedule::latest_decode_time,
+                      Eq(clock_.CurrentTime() + decode_delay)),
+                Field(&FrameDecodeTiming::FrameSchedule::render_time,
+                      Eq(render_time)))));
 }
 
 TEST_F(FrameDecodeTimingTest, FastForwardsFrameTooFarInThePast) {
@@ -102,12 +103,12 @@
   const Timestamp render_time = clock_.CurrentTime();
   timing_.SetTimes(90000, render_time, decode_delay);
 
-  EXPECT_THAT(
-      frame_decode_scheduler_.OnFrameBufferUpdated(90000, 90000, false),
-      Optional(AllOf(Field(&FrameDecodeTiming::FrameSchedule::max_decode_time,
-                           Eq(clock_.CurrentTime() + decode_delay)),
-                     Field(&FrameDecodeTiming::FrameSchedule::render_time,
-                           Eq(render_time)))));
+  EXPECT_THAT(frame_decode_scheduler_.OnFrameBufferUpdated(90000, 90000, false),
+              Optional(AllOf(
+                  Field(&FrameDecodeTiming::FrameSchedule::latest_decode_time,
+                        Eq(clock_.CurrentTime() + decode_delay)),
+                  Field(&FrameDecodeTiming::FrameSchedule::render_time,
+                        Eq(render_time)))));
 }
 
 }  // namespace webrtc