commit 84fbf9ee380ba107d8ba851dcd721b764d396d99
author zijiehe <zijiehe@chromium.org> Fri Oct 21 00:00:37 2016
committer Commit bot <commit-bot@chromium.org> Fri Oct 21 00:00:40 2016
tree 6a7a762e943681a84b807f80fb5cb614bce9e7b4
parent bdb8df895a157bb3b9419c63c22ada41cfba641d

SUCCEEDED macro is misused

SUCCEEDED macro is designed for HRESULT instead of BOOL.
This change exposes my lack of knowledge of native Windows APIs. :(

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=647067

Review-Url: https://codereview.webrtc.org/2440563003
Cr-Commit-Position: refs/heads/master@{#14716}

webrtc/modules/desktop_capture/screen_drawer_win.cc

diff --git a/webrtc/modules/desktop_capture/screen_drawer_win.cc b/webrtc/modules/desktop_capture/screen_drawer_win.cc
index 0b66991..1bc591b 100644
--- a/webrtc/modules/desktop_capture/screen_drawer_win.cc
+++ b/webrtc/modules/desktop_capture/screen_drawer_win.cc
@@ -174,8 +174,8 @@
 }
 
 void ScreenDrawerWin::BringToFront() {
-  if (SUCCEEDED(SetWindowPos(
-      window_, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))) {
+  if (SetWindowPos(window_, HWND_TOPMOST, 0, 0, 0, 0,
+                   SWP_NOMOVE | SWP_NOSIZE) != FALSE) {
     return;
   }