commit 88af20356f5abb11c8efe14b692d4ac383c239a4
author Per Kjellander <perkj@webrtc.org> Mon May 16 17:58:40 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 17 12:29:25 2022
tree 0000511170a3acdbbf4fa680e66871f573621fd9
parent 641a1b11b68f3b8eadee2d138bdf61dce78c8c66

Use ProbeClusterConfig in BitrateProber from GoogCC

Instead of using field trials in BitrateProber for probe duration, use values provided in ProbeClusterConfig from GoogCC.
Field trials are instead read in ProbeController.

To avoid having to do a thread jump for every ProbeClusterConfig, RtpPacketPacer interface is changed to RtpPacketPacer::CreateProbeClusters(std::vector<ProbeClusterConfig>

Deprecates field trial  "WebRTC-Bwe-ProbingConfiguration"

Change-Id: I3991e4b54770601855a3af2d6a16678f11d41c31
Bug: webrtc:14027
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261265
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36911}

call/rtp_transport_controller_send.cc

diff --git a/call/rtp_transport_controller_send.cc b/call/rtp_transport_controller_send.cc
index 393acc4..704b9d5 100644
--- a/call/rtp_transport_controller_send.cc
+++ b/call/rtp_transport_controller_send.cc
@@ -71,7 +71,6 @@
 bool IsRelayed(const rtc::NetworkRoute& route) {
   return route.local.uses_turn() || route.remote.uses_turn();
 }
-
 }  // namespace
 
 RtpTransportControllerSend::PacerSettings::PacerSettings(
@@ -660,8 +659,8 @@
     pacer_.SetPacingRates(update.pacer_config->data_rate(),
                           update.pacer_config->pad_rate());
   }
-  for (const auto& probe : update.probe_cluster_configs) {
-    pacer_.CreateProbeCluster(probe.target_data_rate, probe.id);
+  if (!update.probe_cluster_configs.empty()) {
+    pacer_.CreateProbeClusters(std::move(update.probe_cluster_configs));
   }
   if (update.target_rate) {
     control_handler_->SetTargetRate(*update.target_rate);