commit | 8bd26e12edef129c8305f769af24fc38250e0740 | [log] [tgz] |
---|---|---|
author | Victor Boivie <boivie@webrtc.org> | Wed Jul 07 17:38:43 2021 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 08 10:49:11 2021 |
tree | f183a74cb1f79e249c15879f0767275177f059e1 | |
parent | 706ef1b913a39932893460c73445061887995ca4 [diff] |
dcsctp: Only reset paused streams when peer acks When a single stream is reset, and an outgoing SSN reset request is sent and later acked by the peer sending a reconfiguration response with status=Performed, the sender should unpause the paused stream and reset the SSNs of that (ordered) stream. But only the single stream that was paused, and not all streams. In this scenario, dcSCTP would - when the peer acked the SSN reset request - reset the SSN of all streams. This was found by orphis@webrtc.org using a data channel test application. The peer, if it's a usrsctp client, will ABORT with PROTOCOL_VIOLATION as it has already seen that SSN on that stream but with a different TSN. This bug was introduced when implementing the Round Robin scheduler in https://webrtc-review.googlesource.com/c/src/+/219682. The FCFS scheduler prior to this change was implemented correctly. Bug: webrtc:12952 Change-Id: I3ea144a1df303145f69a5b03aada7f448c8c8163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225266 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34436}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.