Google Git
Sign in
webrtc / src.git / 9e5db68b15087eccd8d2493b4e8539c1657e0f75
commit9e5db68b15087eccd8d2493b4e8539c1657e0f75[log] [tgz]
authorErik Språng <sprang@webrtc.org>Mon Apr 07 14:42:12 2025
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 07 16:10:32 2025
treeef79cb78ef715e38cc5987c6b25ff8d524b49a06
parent04413d62f754a7b1a3a2d8c3df23bcde040112b2 [diff]
[M135] Protect queue in FrameInstrumentationGenerator with a mutex

`OnCapturedFrame` and `OnEncodedImage` may be called from different
threads, hence synchronization is needed. There have been reports of crashes caused by race condition: https://issues.chromium.org/issues/404925575

// No-Try due to iwyu_verifier seemingly not working on this branch.
(cherry picked from commit 4447d6b800c1af20955844f082e1cb29158a7790)

No-Try: True
Bug: webrtc:358039777, chromium:404925575
Change-Id: I070b9b7309c28ab50de2268af55adbe26e559f6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383021
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#44268}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/385083
Cr-Commit-Position: refs/branch-heads/7049@{#3}
Cr-Branched-From: caae8ec03bedd938b99c7a11b6455878c4f93e75-refs/heads/main@{#44027}
4 files changed
tree: ef79cb78ef715e38cc5987c6b25ff8d524b49a06
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .git-blame-ignore-revs
  30. .gitignore
  31. .gn
  32. .mailmap
  33. .style.yapf
  34. .vpython3
  35. AUTHORS
  36. BUILD.gn
  37. CODE_OF_CONDUCT.md
  38. codereview.settings
  39. DEPS
  40. DIR_METADATA
  41. ENG_REVIEW_OWNERS
  42. LICENSE
  43. license_template.txt
  44. native-api.md
  45. OWNERS
  46. OWNERS_INFRA
  47. PATENTS
  48. PRESUBMIT.py
  49. presubmit_test.py
  50. presubmit_test_mocks.py
  51. pylintrc
  52. pylintrc_old_style
  53. README.chromium
  54. README.md
  55. WATCHLISTS
  56. webrtc.gni
  57. webrtc_lib_link_test.cc
  58. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info