commit a1d035655eb6e3a73ae5ab16882987327d7bc643
author Alessio Bazzica <alessiob@webrtc.org> Mon Sep 19 16:05:29 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 20 08:58:38 2022
tree 76c1672f728e2bd1d3e0f31d7af19711931cc358
parent 7d1f6bb86cfc3751d4f3ad281d4e56b0266a9c57

`RtpPacketInfo`: new ctor + deprecated ctors clean-up

New ctor added without optional and media specific fields.

Bug: webrtc:10739, b/246753278
Change-Id: I7e15849aced6ed0a7ada725ea171a15ea1e9bc5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275941
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38124}

api/rtp_packet_infos_unittest.cc

diff --git a/api/rtp_packet_infos_unittest.cc b/api/rtp_packet_infos_unittest.cc
index e83358f..a90cfa0 100644
--- a/api/rtp_packet_infos_unittest.cc
+++ b/api/rtp_packet_infos_unittest.cc
@@ -27,12 +27,23 @@
 }  // namespace
 
 TEST(RtpPacketInfosTest, BasicFunctionality) {
-  RtpPacketInfo p0(123, {1, 2}, 89, 5, AbsoluteCaptureTime{45, 78},
-                   Timestamp::Millis(7));
-  RtpPacketInfo p1(456, {3, 4}, 89, 4, AbsoluteCaptureTime{13, 21},
-                   Timestamp::Millis(1));
-  RtpPacketInfo p2(789, {5, 6}, 88, 1, AbsoluteCaptureTime{99, 78},
-                   Timestamp::Millis(7));
+  RtpPacketInfo p0(/*ssrc=*/123, /*csrcs=*/{1, 2}, /*rtp_timestamp=*/89,
+                   /*receive_time=*/Timestamp::Millis(7));
+  p0.set_audio_level(5);
+  p0.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 45, .estimated_capture_clock_offset = 78});
+
+  RtpPacketInfo p1(/*ssrc=*/456, /*csrcs=*/{3, 4}, /*rtp_timestamp=*/89,
+                   /*receive_time=*/Timestamp::Millis(1));
+  p1.set_audio_level(4);
+  p1.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 13, .estimated_capture_clock_offset = 21});
+
+  RtpPacketInfo p2(/*ssrc=*/789, /*csrcs=*/{5, 6}, /*rtp_timestamp=*/88,
+                   /*receive_time=*/Timestamp::Millis(7));
+  p2.set_audio_level(1);
+  p2.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 99, .estimated_capture_clock_offset = 78});
 
   RtpPacketInfos x({p0, p1, p2});
 
@@ -55,12 +66,23 @@
 }
 
 TEST(RtpPacketInfosTest, CopyShareData) {
-  RtpPacketInfo p0(123, {1, 2}, 89, 5, AbsoluteCaptureTime{45, 78},
-                   Timestamp::Millis(7));
-  RtpPacketInfo p1(456, {3, 4}, 89, 4, AbsoluteCaptureTime{13, 21},
-                   Timestamp::Millis(1));
-  RtpPacketInfo p2(789, {5, 6}, 88, 1, AbsoluteCaptureTime{99, 78},
-                   Timestamp::Millis(7));
+  RtpPacketInfo p0(/*ssrc=*/123, /*csrcs=*/{1, 2}, /*rtp_timestamp=*/89,
+                   /*receive_time=*/Timestamp::Millis(7));
+  p0.set_audio_level(5);
+  p0.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 45, .estimated_capture_clock_offset = 78});
+
+  RtpPacketInfo p1(/*ssrc=*/456, /*csrcs=*/{3, 4}, /*rtp_timestamp=*/89,
+                   /*receive_time=*/Timestamp::Millis(1));
+  p1.set_audio_level(4);
+  p1.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 13, .estimated_capture_clock_offset = 21});
+
+  RtpPacketInfo p2(/*ssrc=*/789, /*csrcs=*/{5, 6}, /*rtp_timestamp=*/88,
+                   /*receive_time=*/Timestamp::Millis(7));
+  p2.set_audio_level(1);
+  p2.set_absolute_capture_time(AbsoluteCaptureTime{
+      .absolute_capture_timestamp = 99, .estimated_capture_clock_offset = 78});
 
   RtpPacketInfos lhs({p0, p1, p2});
   RtpPacketInfos rhs = lhs;