)]}' { "commit": "a7f2d84ad12cbdf41becc980a7dba03322dd5a4e", "tree": "91cae77a5339de9ee1622075f0544c28f27d034b", "parents": [ "0e6d2f5118fc0605773e63c7aeea127b30239510" ], "author": { "name": "Per Kjellander", "email": "perkj@webrtc.org", "time": "Wed Jan 10 15:54:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 10 15:55:04 2018" }, "message": "Revert \"Revert \"GN rtc_* templates: Set default visibility to webrtc_root + \"/*\"\"\"\n\nThis reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613.\n\nReason for revert: \nThe problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660\n\nOriginal change\u0027s description:\n\u003e Revert \"GN rtc_* templates: Set default visibility to webrtc_root + \"/*\"\"\n\u003e \n\u003e This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.\n\u003e \n\u003e Reason for revert: \n\u003e \n\u003e Breaks Chrome FYI:\n\u003e \n\u003e /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check\n\u003e -\u003e returned 1\n\u003e ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.\n\u003e static_library(target_name) {\n\u003e ^----------------------------\n\u003e The item //content/renderer:renderer\n\u003e can not depend on //third_party/webrtc/media:rtc_internal_video_codecs\n\u003e because it is not in //third_party/webrtc/media:rtc_internal_video_codecs\u0027s visibility list: [\n\u003e //third_party/webrtc/*\n\u003e //third_party/webrtc_overrides/*\n\u003e ]\n\u003e \n\u003e https://logs.chromium.org/v/?s\u003dchromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout\n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e GN rtc_* templates: Set default visibility to webrtc_root + \"/*\"\n\u003e \u003e \n\u003e \u003e This means that by default, targets are visible to everything under\n\u003e \u003e the WebRTC root, but not visible to anything else.\n\u003e \u003e \n\u003e \u003e API targets are manually tagged with visibility \"*\", so that targets\n\u003e \u003e outside the WebRTC tree can see them.\n\u003e \u003e \n\u003e \u003e BUG\u003dwebrtc:8254\n\u003e \u003e \n\u003e \u003e Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509\n\u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/24140\n\u003e \u003e Reviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e Commit-Queue: Karl Wiberg \u003ckwiberg@webrtc.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#21548}\n\u003e \n\u003e TBR\u003dmbonadei@webrtc.org,kwiberg@webrtc.org\n\u003e \n\u003e Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: webrtc:8254\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/38760\n\u003e Reviewed-by: Per Kjellander \u003cperkj@webrtc.org\u003e\n\u003e Commit-Queue: Per Kjellander \u003cperkj@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#21555}\n\nTBR\u003dmbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org\n\nChange-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: webrtc:8254\nReviewed-on: https://webrtc-review.googlesource.com/38860\nReviewed-by: Per Kjellander \u003cperkj@webrtc.org\u003e\nCommit-Queue: Per Kjellander \u003cperkj@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#21558}", "tree_diff": [ { "type": "modify", "old_id": "6ac235b34996ef5fec058df66879293f14659d2b", "old_mode": 33188, "old_path": "api/BUILD.gn", "new_id": "dcda3699704ab6a91c90b4c41e26aa514bb84872", "new_mode": 33188, "new_path": "api/BUILD.gn" }, { "type": "modify", "old_id": "01dc12459eeb3cff9eed0ae15b12b8938a082757", "old_mode": 33188, "old_path": "api/audio_codecs/BUILD.gn", "new_id": "f73026001541cdcae366308cc5f29be2f481e4b6", "new_mode": 33188, "new_path": "api/audio_codecs/BUILD.gn" }, { "type": "modify", "old_id": "8f06a8f332856a9ad5afe50b582d8d242bd5a506", "old_mode": 33188, "old_path": "api/audio_codecs/L16/BUILD.gn", "new_id": "f047bf132de4d216d68051dd7312155b82f012bc", "new_mode": 33188, "new_path": "api/audio_codecs/L16/BUILD.gn" }, { "type": "modify", "old_id": "aa86490a737e58c9c38322b3953f396b4eb23d2e", "old_mode": 33188, "old_path": "api/audio_codecs/g711/BUILD.gn", "new_id": "b62c67907690f009e75c6fde3df876bd564eea8f", "new_mode": 33188, "new_path": "api/audio_codecs/g711/BUILD.gn" }, { "type": "modify", "old_id": "5af7e5c223e3ea1324e6a0ce3a890893506b7f62", "old_mode": 33188, "old_path": "api/audio_codecs/g722/BUILD.gn", "new_id": "0d12195b69244a2f8f9e30c8e36fa794d7351d18", "new_mode": 33188, "new_path": "api/audio_codecs/g722/BUILD.gn" }, { "type": "modify", "old_id": "0f5f80dfe24b7b5ac82398d5c70f5361b22b3b35", "old_mode": 33188, "old_path": "api/audio_codecs/ilbc/BUILD.gn", "new_id": "944d4eb8745b89529312bddfde75c1da9956db3b", "new_mode": 33188, "new_path": "api/audio_codecs/ilbc/BUILD.gn" }, { "type": "modify", "old_id": "5bd477d1d7eeded45ad17a7636eecaba6ea5e256", "old_mode": 33188, "old_path": "api/audio_codecs/isac/BUILD.gn", "new_id": "f63435c93aab33a37d0dcde393b8d864401a28cb", "new_mode": 33188, "new_path": "api/audio_codecs/isac/BUILD.gn" }, { "type": "modify", "old_id": "9d07c95c91c297ec56a072fe534ffa662b3a2da9", "old_mode": 33188, "old_path": "api/audio_codecs/opus/BUILD.gn", "new_id": "13a4b5d3ee1b60341bf7e1b1793ae62e3ce4f27d", "new_mode": 33188, "new_path": "api/audio_codecs/opus/BUILD.gn" }, { "type": "modify", "old_id": "6f3623db566aee4ac3c47c6ac7037f6d1194d32c", "old_mode": 33188, "old_path": "api/video_codecs/BUILD.gn", "new_id": "5da89807561b2c91ff339dbcdb518e7266e9f377", "new_mode": 33188, "new_path": "api/video_codecs/BUILD.gn" }, { "type": "modify", "old_id": "4e017103c414c724f8aaaf28cbb82f664b426393", "old_mode": 33188, "old_path": "audio/utility/BUILD.gn", "new_id": "aa8445c90b31dbd0953a6632caac9c309b80d6a9", "new_mode": 33188, "new_path": "audio/utility/BUILD.gn" }, { "type": "modify", "old_id": "99de0c9cfbc321bcfa97d039f0b0dc4464cb4804", "old_mode": 33188, "old_path": "call/BUILD.gn", "new_id": "90460e76706b9d3fdf41ac7a912d14ac474e72c0", "new_mode": 33188, "new_path": "call/BUILD.gn" }, { "type": "modify", "old_id": "27287ec9665bc3172ba4131f9e1e5db19f9075e7", "old_mode": 33188, "old_path": "common_audio/BUILD.gn", "new_id": "34cdddc8036cd2c2c054e238f5f89e643bf7f5b3", "new_mode": 33188, "new_path": "common_audio/BUILD.gn" }, { "type": "modify", "old_id": "68b102b0613a4a7c56686e1a32a4d425d5177919", "old_mode": 33188, "old_path": "common_video/BUILD.gn", "new_id": "1c298fdba093e47df4f64addf32e5f172287383e", "new_mode": 33188, "new_path": "common_video/BUILD.gn" }, { "type": "modify", "old_id": "e755b16345ad6508d87e049650fe33ff9b728f35", "old_mode": 33188, "old_path": "logging/BUILD.gn", "new_id": "7ecb0fa8d663e0f3ef56e12ff192dff6361006a1", "new_mode": 33188, "new_path": "logging/BUILD.gn" }, { "type": "modify", "old_id": "63792409b3dddaadf884b5883478a5cb74375fc4", "old_mode": 33188, "old_path": "media/BUILD.gn", "new_id": "24d9c2e5d09cdb6c75d3b1e042fde7eb96d2205c", "new_mode": 33188, "new_path": "media/BUILD.gn" }, { "type": "modify", "old_id": "1f93e99d3cffe7bc6fe63bad01d9ab873ad7f043", "old_mode": 33188, "old_path": "modules/BUILD.gn", "new_id": "b5de323fc46b9833c9adb429cc5fe7f190274dae", "new_mode": 33188, "new_path": "modules/BUILD.gn" }, { "type": "modify", "old_id": "1d6a70c8edef721f79875f0b88b4fb3cf528eac2", "old_mode": 33188, "old_path": "modules/audio_coding/BUILD.gn", "new_id": "f9eea0c029e4d9f2936aca9dc6a459efb9218ed8", "new_mode": 33188, "new_path": "modules/audio_coding/BUILD.gn" }, { "type": "modify", "old_id": "3b70c0731029ecca1ae45ce0d13ef7b18eb436c7", "old_mode": 33188, "old_path": "modules/audio_device/BUILD.gn", "new_id": "eac2dc0be0f71c59b0664ee84cbb7f1564d37260", "new_mode": 33188, "new_path": "modules/audio_device/BUILD.gn" }, { "type": "modify", "old_id": "c5724e5083db6a4c991c77dc770b979e19266420", "old_mode": 33188, "old_path": "modules/audio_processing/BUILD.gn", "new_id": "4de77c7c428b8fdfd5a396badb2182c4712b86d7", "new_mode": 33188, "new_path": "modules/audio_processing/BUILD.gn" }, { "type": "modify", "old_id": "2e44509ae995d68a5c4338c1f2046e5ff370cf34", "old_mode": 33188, "old_path": "modules/audio_processing/aec_dump/BUILD.gn", "new_id": "aac4b0a49d56730cd4fe91de6d5630203104c3a0", "new_mode": 33188, "new_path": "modules/audio_processing/aec_dump/BUILD.gn" }, { "type": "modify", "old_id": "a791c33bdf770fa5a7b024d8f7a45cbe358f4d3a", "old_mode": 33188, "old_path": "modules/bitrate_controller/BUILD.gn", "new_id": "165db62cce955cd598dbf18ef89398df1c5bae63", "new_mode": 33188, "new_path": "modules/bitrate_controller/BUILD.gn" }, { "type": "modify", "old_id": "e2c79a063afd42733d36f4b2b292f021bd29a1f2", "old_mode": 33188, "old_path": "modules/congestion_controller/BUILD.gn", "new_id": "46c304765854a995c92f8563607fcd522b9b7e9e", "new_mode": 33188, "new_path": "modules/congestion_controller/BUILD.gn" }, { "type": "modify", "old_id": "fa414b768487eda83d0ccb7ec953a51989e4c290", "old_mode": 33188, "old_path": "modules/desktop_capture/BUILD.gn", "new_id": "04fef212be92208f3a8965eb243373184cc9eb5c", "new_mode": 33188, "new_path": "modules/desktop_capture/BUILD.gn" }, { "type": "modify", "old_id": "589b2818cc1c95729fc9885c74a2ddc94993ce6e", "old_mode": 33188, "old_path": "modules/media_file/BUILD.gn", "new_id": "4fff59de24642d3deebc89a2fd7af73c3348ac1a", "new_mode": 33188, "new_path": "modules/media_file/BUILD.gn" }, { "type": "modify", "old_id": "0ca6b872b6b9eafbb5f50ec2f0bdf121378e300a", "old_mode": 33188, "old_path": "modules/remote_bitrate_estimator/BUILD.gn", "new_id": "c57b4982ed9204b55c6c604c026d193dcc4750b1", "new_mode": 33188, "new_path": "modules/remote_bitrate_estimator/BUILD.gn" }, { "type": "modify", "old_id": "f07ff1adc8ea1dce9778e44837ded26a26d61ff6", "old_mode": 33188, "old_path": "modules/rtp_rtcp/BUILD.gn", "new_id": "bf94013bf8cc2b7fdb9fb00dcdd72df30c57bacf", "new_mode": 33188, "new_path": "modules/rtp_rtcp/BUILD.gn" }, { "type": "modify", "old_id": "e3de364f16a47292dbe21b5ad7821d25eb68bc5e", "old_mode": 33188, "old_path": "modules/utility/BUILD.gn", "new_id": "fbfa61ec1680d1ab705a8cd8e9c512783016acd4", "new_mode": 33188, "new_path": "modules/utility/BUILD.gn" }, { "type": "modify", "old_id": "8df5205f12f49d5d1817b57781febb67357b01bc", "old_mode": 33188, "old_path": "modules/video_capture/BUILD.gn", "new_id": "63785646f0eb245bb5d7ec8c1261c07134869093", "new_mode": 33188, "new_path": "modules/video_capture/BUILD.gn" }, { "type": "modify", "old_id": "2ca7f1401c5e0273e545d45d65cc8eedeb0bf078", "old_mode": 33188, "old_path": "modules/video_coding/BUILD.gn", "new_id": "efd0f25415747475fa98a4880e7de7b4477a5f9b", "new_mode": 33188, "new_path": "modules/video_coding/BUILD.gn" }, { "type": "modify", "old_id": "4fd5e8826bafd270c92e80e2933e349d561fc346", "old_mode": 33188, "old_path": "modules/video_processing/BUILD.gn", "new_id": "351e5792f8ec456c8d9cca1017e20913812aef77", "new_mode": 33188, "new_path": "modules/video_processing/BUILD.gn" }, { "type": "modify", "old_id": "f9c75cf2d863bb6636151666d544dd867be231d7", "old_mode": 33188, "old_path": "p2p/BUILD.gn", "new_id": "f72ce164f1fa80dac815cc1585046c3f9e231692", "new_mode": 33188, "new_path": "p2p/BUILD.gn" }, { "type": "modify", "old_id": "cd1a489d7879c7a670e0805fc70f9776e244c296", "old_mode": 33188, "old_path": "pc/BUILD.gn", "new_id": "09fa2c253398faa26cd8db0263527764fbd5c296", "new_mode": 33188, "new_path": "pc/BUILD.gn" }, { "type": "modify", "old_id": "cc475f7dfd7f14cd7c1a164c16325a67cac5df5d", "old_mode": 33188, "old_path": "rtc_base/BUILD.gn", "new_id": "479f67f66bf5108a47b8b1953dc2449327ca616d", "new_mode": 33188, "new_path": "rtc_base/BUILD.gn" }, { "type": "modify", "old_id": "8a04b14138ae1b92282ce5f555b939d9357ab73b", "old_mode": 33188, "old_path": "rtc_tools/BUILD.gn", "new_id": "ac7e44d8f4523b73a5829b3f74c7ec960b768163", "new_mode": 33188, "new_path": "rtc_tools/BUILD.gn" }, { "type": "modify", "old_id": "14d529a4dc8e8812106aea805f8843c8a781deb4", "old_mode": 33188, "old_path": "sdk/BUILD.gn", "new_id": "ef243d0eedabceed11ab699dc0c8f6ff78f49605", "new_mode": 33188, "new_path": "sdk/BUILD.gn" }, { "type": "modify", "old_id": "366961de1b678df50b4262e7da8910ffdd184c74", "old_mode": 33188, "old_path": "sdk/android/BUILD.gn", "new_id": "970971441561d85559215a75e3dd2574cbd644fc", "new_mode": 33188, "new_path": "sdk/android/BUILD.gn" }, { "type": "modify", "old_id": "92cd1a9b037216857486c48185a8e393c1c54ee6", "old_mode": 33188, "old_path": "stats/BUILD.gn", "new_id": "92231cef02ac9138110bfd8d3be405801d040d69", "new_mode": 33188, "new_path": "stats/BUILD.gn" }, { "type": "modify", "old_id": "ca9bad2fc6c8a43c4bc94d31cc0351a25ae205ce", "old_mode": 33188, "old_path": "style-guide.md", "new_id": "d8fbaae6d49e0ecba0f07c9a967955b93b566de0", "new_mode": 33188, "new_path": "style-guide.md" }, { "type": "modify", "old_id": "f999e211b759affb0ed3b74569513d4489229055", "old_mode": 33188, "old_path": "system_wrappers/BUILD.gn", "new_id": "358137fa6c3fb32e13f1e157513e2f48bb8774a9", "new_mode": 33188, "new_path": "system_wrappers/BUILD.gn" }, { "type": "modify", "old_id": "fe8a89e0b1200ffdf25e0f32b933899a8eb7d3c1", "old_mode": 33188, "old_path": "test/BUILD.gn", "new_id": "00a7ae5656092a960c57e613f28400ae0e237573", "new_mode": 33188, "new_path": "test/BUILD.gn" }, { "type": "modify", "old_id": "a10b792677ae8b65e0b28bff477d3401ec1072bf", "old_mode": 33188, "old_path": "voice_engine/BUILD.gn", "new_id": "bb9253fd95229a386119dfc3ed51faae1627198a", "new_mode": 33188, "new_path": "voice_engine/BUILD.gn" }, { "type": "modify", "old_id": "b8ceb8e0f0e1591cead330134bed01d16f273b88", "old_mode": 33188, "old_path": "webrtc.gni", "new_id": "ffa92d4c4a4c3af3e19ba6e6d59888b0f4399a3d", "new_mode": 33188, "new_path": "webrtc.gni" } ] }