)]}'
{
  "commit": "ae331349c64c2307a2ff06f2d3e1baedefc57d75",
  "tree": "7f50e11e928578f042a2b459397e17fcedf6d36f",
  "parents": [
    "8786f637b292d3f91c771f6e08a510591ac51bdc"
  ],
  "author": {
    "name": "Henrik Kjellander",
    "email": "kjellander@webrtc.org",
    "time": "Tue Apr 28 14:08:23 2015"
  },
  "committer": {
    "name": "Henrik Kjellander",
    "email": "kjellander@webrtc.org",
    "time": "Tue Apr 28 14:08:29 2015"
  },
  "message": "Always specify current OS when syncing Chromium.\n\nRecently, we\u0027ve hit a rare case of a dependency being\npresent only below \u0027unix\u0027 and not in the \u0027android\u0027 section\nof the DEPS file in Chromium (src/third_party/junit/src).\n\nThis exposed a bug in our sync_chromium.py script, which is that\nwhen the --deps flag is passed to gclient sync, _only_ that platform\nis processed. That means our Android builders synced with --deps\u003dandroid\nand thus only getting the Android deps, not the \u0027unix\u0027 ones (Linux).\nThat behavior is different from a regular gclient sync, where both\nthe current platform\u0027s DEPS and the one specified by appending a target_os\nvariable into .gclient is used.\n\nEnsuring that we pass both the current platform and the optionally specified\nDEPS platform into our sync_chromium.py sync, gives us the same behavior\nas a regular sync for the special Chromium sync we use.\n\nTESTED\u003d\nFirst:\nrm chromium/.last_sync_chromium\nThen I ran without this patch and with target_os \u003d [\"android\"] in .gclient. Verified\nthat --deps\u003dandroid was passed.\nWith this patch, I repeated the above and verified --deps\u003dunix,android was passed.\n\nR\u003dphoglund@webrtc.org\n\nReview URL: https://webrtc-codereview.appspot.com/52379004\n\nCr-Commit-Position: refs/heads/master@{#9103}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "35d693e543f082241df24a4cfb26894eb0f60f20",
      "old_mode": 33261,
      "old_path": "sync_chromium.py",
      "new_id": "08b10427d85bb7d989c8780e0fd0147ba1b03f1e",
      "new_mode": 33261,
      "new_path": "sync_chromium.py"
    }
  ]
}