commit c032109cda1de08ad06502c5924c0b82611b2f7e
author Ilya Nikolaevskiy <ilnik@webrtc.org> Mon Mar 11 10:18:26 2019
committer Commit Bot <commit-bot@chromium.org> Wed Mar 13 14:59:02 2019
tree 1bcabf5e49a7674258d39dbd111e2a2cc9164656
parent 133b307c7d6c95d8421c918cbb7e4c62cd7a894a

Improve bitstream dumping logic in VideoReceiveStream

Specifying relative path like "~" somehow doesn't work in some cases.
To pass an absolute path some parameter rewriting is required.
Also, as the stream gets recreated several times at the beginning of the
call, append the time to the filename to make them unique.

Bug: none
Change-Id: I1c914f9081adb4ac5c34584d96e542e8a863547b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126700
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27101}

video/video_receive_stream.cc

diff --git a/video/video_receive_stream.cc b/video/video_receive_stream.cc
index 0f87d65..f84bced 100644
--- a/video/video_receive_stream.cc
+++ b/video/video_receive_stream.cc
@@ -338,11 +338,16 @@
 
     std::string decoded_output_file =
         field_trial::FindFullName("WebRTC-DecoderDataDumpDirectory");
+    // Because '/' can't be used inside a field trial parameter, we use ':'
+    // instead.
+    std::replace(decoded_output_file.begin(), decoded_output_file.end(), ':',
+                 '/');
     if (!decoded_output_file.empty()) {
       char filename_buffer[256];
       rtc::SimpleStringBuilder ssb(filename_buffer);
       ssb << decoded_output_file << "/webrtc_receive_stream_"
-          << this->config_.rtp.local_ssrc << ".ivf";
+          << this->config_.rtp.remote_ssrc << "-" << rtc::TimeMicros()
+          << ".ivf";
       video_decoder = absl::make_unique<FrameDumpingDecoder>(
           std::move(video_decoder), FileWrapper::OpenWriteOnly(ssb.str()));
     }