commit c2d37895a209b73134b49250aad3358b662bdf91
author Jakob Ivarsson <jakobi@webrtc.org> Mon Apr 10 17:40:10 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 11 13:03:12 2023
tree 55c7f1dc502c7916905d65ef66aeec6eb9c3f4d3
parent aab1bdea1104e82ba8e27424226e1c117ce5c2c6

Fix event log visualizer crash when NetEq input creation fails.

This can happen when there are audio SSRCs in the event log without any
associated events.

Issue was introduced in
https://webrtc-review.googlesource.com/c/src/+/300300

Bug: None
Change-Id: Ib0e009095bf67633812d937aa5a9e65e2cd8958a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300743
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39806}

rtc_tools/rtc_event_log_visualizer/analyze_audio.cc

diff --git a/rtc_tools/rtc_event_log_visualizer/analyze_audio.cc b/rtc_tools/rtc_event_log_visualizer/analyze_audio.cc
index 6a9ef9e..29dc26c 100644
--- a/rtc_tools/rtc_event_log_visualizer/analyze_audio.cc
+++ b/rtc_tools/rtc_event_log_visualizer/analyze_audio.cc
@@ -222,6 +222,9 @@
     int file_sample_rate_hz) {
   std::unique_ptr<test::NetEqInput> input =
       test::CreateNetEqEventLogInput(parsed_log, ssrc);
+  if (!input) {
+    return nullptr;
+  }
 
   constexpr int kReplacementPt = 127;
   std::set<uint8_t> cn_types;
@@ -263,8 +266,11 @@
                                   int file_sample_rate_hz) {
   NetEqStatsGetterMap neteq_stats;
   for (uint32_t ssrc : parsed_log.incoming_audio_ssrcs()) {
-    neteq_stats[ssrc] = CreateNetEqTestAndRun(
+    std::unique_ptr<test::NetEqStatsGetter> stats = CreateNetEqTestAndRun(
         parsed_log, ssrc, replacement_file_name, file_sample_rate_hz);
+    if (stats) {
+      neteq_stats[ssrc] = std::move(stats);
+    }
   }
   return neteq_stats;
 }