commit c2ee2c86f905991a8cd05ee1f35bea105b41e4e0
author Peter Thatcher <pthatcher@chromium.org> Fri Aug 07 23:05:34 2015
committer Peter Thatcher <pthatcher@chromium.org> Fri Aug 07 23:05:42 2015
tree 7f972ad0b4dcd89fda73a276a20cdb14a6024d04
parent eb04d687d3bd8d4c7cbe9eb00f0b8c77a873b428

Refactor the relationship between BaseChannel and MediaChannel so that we send over all the parameters in one method call rather then having them broken up into multiple method calls.  This should allow future refactorings of the WebRtcVideoEngine2 to not recreate configurations so many times, and have more simple code as well.

R=deadbeef@webrtc.org, pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1229283003 .

Cr-Commit-Position: refs/heads/master@{#9690}

talk/media/webrtc/webrtcvoiceengine.cc

diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 6a448c8..e288e70 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -1743,6 +1743,24 @@
   DeleteChannel(voe_channel());
 }
 
+bool WebRtcVoiceMediaChannel::SetSendParameters(
+    const AudioSendParameters& params) {
+  // TODO(pthatcher): Refactor this to be more clean now that we have
+  // all the information at once.
+  return (SetSendCodecs(params.codecs) &&
+          SetSendRtpHeaderExtensions(params.extensions) &&
+          SetMaxSendBandwidth(params.max_bandwidth_bps) &&
+          SetOptions(params.options));
+}
+
+bool WebRtcVoiceMediaChannel::SetRecvParameters(
+    const AudioRecvParameters& params) {
+  // TODO(pthatcher): Refactor this to be more clean now that we have
+  // all the information at once.
+  return (SetRecvCodecs(params.codecs) &&
+          SetRecvRtpHeaderExtensions(params.extensions));
+}
+
 bool WebRtcVoiceMediaChannel::SetOptions(const AudioOptions& options) {
   LOG(LS_INFO) << "Setting voice channel options: "
                << options.ToString();