| commit | c3f3515f8ea78c0a8a5026639e605a9bdfda4add | [log] [tgz] |
|---|---|---|
| author | skvlad <skvlad@webrtc.org> | Fri Sep 02 20:23:46 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Sep 02 20:23:52 2016 |
| tree | c21f833abfd6f766411d7fd074d9c9aa1f2aa0fc | |
| parent | 1afdf99f9c00155b0c250e9a358de0184933b27c [diff] |
Fixed flaky VideoSendStreamTest::SupportsAbsoluteSendTime This test failed on the memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/6704/steps/video_engine_tests/logs/stdio The test assumed that the absolute send time header extension can never be zero. It's a timestamp truncated to 24 bits, and zero is not a special value - so it can very rarely end up being precisely zero. The fix makes the test wait for at least one packet having a non-zero send time. I've considered changing the test to use a fake clock instead to ensure that not only the value is non-zero, but that it indeed reflects the system timestamp - but that involves changing a very large number of files. Besides, other tests in this file don't verify values for header extensions where zeroes are allowed. NOTRY=true Review-Url: https://codereview.webrtc.org/2307693002 Cr-Commit-Position: refs/heads/master@{#14056}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.