commit c4f047d62735c70854be6e26a8007012ccd9ffac
author Erik Språng <sprang@webrtc.org> Fri Jul 19 11:34:11 2019
committer Commit Bot <commit-bot@chromium.org> Wed Jul 24 13:05:56 2019
tree 0b9245be70519356080f465f49ff684c8cb233a8
parent 414e1b46ca0c2efd2521a42bfc48e072ec46ace7

Make WebRTC-Pacer-LegacyPacketReferencing default off

This makes the code path where packets are directly owned by PacedSender
rather that being temporarily put in the RtpPacketHistory the default.

Functionally, this should essentially be a noop, with only minor timing
differences.

The old code-path will stay around for a short while and then be
removed once we are certain there are no regressions.

Bug: webrtc:10633
Change-Id: Id6360dea48fd0c9d46fde6f5eee93726d4f11d13
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146212
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28660}

modules/pacing/paced_sender.cc

diff --git a/modules/pacing/paced_sender.cc b/modules/pacing/paced_sender.cc
index 0b3e2ca..58ae5fa 100644
--- a/modules/pacing/paced_sender.cc
+++ b/modules/pacing/paced_sender.cc
@@ -100,7 +100,7 @@
       queue_time_limit(kMaxQueueLengthMs),
       account_for_audio_(false),
       legacy_packet_referencing_(
-          !IsDisabled(*field_trials_, "WebRTC-Pacer-LegacyPacketReferencing")) {
+          IsEnabled(*field_trials_, "WebRTC-Pacer-LegacyPacketReferencing")) {
   if (!drain_large_queues_) {
     RTC_LOG(LS_WARNING) << "Pacer queues will not be drained,"
                            "pushback experiment must be enabled.";

modules/rtp_rtcp/source/rtp_sender.cc

diff --git a/modules/rtp_rtcp/source/rtp_sender.cc b/modules/rtp_rtcp/source/rtp_sender.cc
index 69066b8..98f93cc 100644
--- a/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/modules/rtp_rtcp/source/rtp_sender.cc
@@ -132,13 +132,6 @@
   return trials.Lookup(name).find("Enabled") == 0;
 }
 
-bool IsDisabled(absl::string_view name,
-                const WebRtcKeyValueConfig* field_trials) {
-  FieldTrialBasedConfig default_trials;
-  auto& trials = field_trials ? *field_trials : default_trials;
-  return trials.Lookup(name).find("Disabled") == 0;
-}
-
 bool HasBweExtension(const RtpHeaderExtensionMap& extensions_map) {
   return extensions_map.IsRegistered(kRtpExtensionTransportSequenceNumber) ||
          extensions_map.IsRegistered(kRtpExtensionTransportSequenceNumber02) ||
@@ -199,8 +192,8 @@
       send_side_bwe_with_overhead_(
           IsEnabled("WebRTC-SendSideBwe-WithOverhead", config.field_trials)),
       pacer_legacy_packet_referencing_(
-          !IsDisabled("WebRTC-Pacer-LegacyPacketReferencing",
-                      config.field_trials)) {
+          IsEnabled("WebRTC-Pacer-LegacyPacketReferencing",
+                    config.field_trials)) {
   // This random initialization is not intended to be cryptographic strong.
   timestamp_offset_ = random_.Rand<uint32_t>();
   // Random start, 16 bits. Can't be 0.
@@ -282,7 +275,7 @@
               .find("Enabled") == 0),
       pacer_legacy_packet_referencing_(
           field_trials.Lookup("WebRTC-Pacer-LegacyPacketReferencing")
-              .find("Disabled") != 0) {
+              .find("Enabled") == 0) {
   // This random initialization is not intended to be cryptographic strong.
   timestamp_offset_ = random_.Rand<uint32_t>();
   // Random start, 16 bits. Can't be 0.