Remove line number from rtc::Location
Concatenating __FILE__ with __LINE__ prevents the compiler from
aliasing strings within the same file, contributing ~30KB of .text
bloat. Chrome already omits from the file number from its Location
type so it doesn't seem to be a big loss.
Bug: b/145168048
Change-Id: I000bfdf43f4eb90f8b63ed017b08c1b5a7a84a6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160744
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29994}
diff --git a/rtc_base/location.cc b/rtc_base/location.cc
index d3c911f..0842549 100644
--- a/rtc_base/location.cc
+++ b/rtc_base/location.cc
@@ -14,24 +14,10 @@
namespace rtc {
-Location::Location(const char* function_name, const char* file_and_line)
- : function_name_(function_name), file_and_line_(file_and_line) {}
-
-Location::Location() : function_name_("Unknown"), file_and_line_("Unknown") {}
-
-Location::Location(const Location& other)
- : function_name_(other.function_name_),
- file_and_line_(other.file_and_line_) {}
-
-Location& Location::operator=(const Location& other) {
- function_name_ = other.function_name_;
- file_and_line_ = other.file_and_line_;
- return *this;
-}
-
std::string Location::ToString() const {
char buf[256];
- snprintf(buf, sizeof(buf), "%s@%s", function_name_, file_and_line_);
+ snprintf(buf, sizeof(buf), "%s@%s:%d", function_name_, file_name_,
+ line_number_);
return buf;
}
