| commit | c80f95511422fae261140e1eb3018d7cf88238b1 | [log] [tgz] |
|---|---|---|
| author | Erik Språng <sprang@webrtc.org> | Fri Mar 12 15:36:49 2021 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 12 17:12:25 2021 |
| tree | 0a190ef2f3d67a4cfda83be78875445ab2c63b13 | |
| parent | 5eda59c96fb3f90963afd5524ff7a78999ce2c7c [diff] |
Avoid log spam when decoder implementation changes A refactoring (https://webrtc-review.googlesource.com/c/src/+/196520) of decoder metadata handling introduced a bug which causes us to log an info-level entry for every frame decoded if the implementation changes during runtime (e.g. due to software fallback). This CL fixes that to avoid spamming the logs. Bug: webrtc:12271 Change-Id: I89016351b8752b259299c4cf56c6feddcca43460 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211664 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33451}
diff --git a/modules/video_coding/generic_decoder.cc b/modules/video_coding/generic_decoder.cc index bd13d21..85c68da 100644 --- a/modules/video_coding/generic_decoder.cc +++ b/modules/video_coding/generic_decoder.cc
@@ -272,7 +272,7 @@ if (decoder_info != decoder_info_) { RTC_LOG(LS_INFO) << "Changed decoder implementation to: " << decoder_info.ToString(); - + decoder_info_ = decoder_info; _callback->OnDecoderImplementationName( decoder_info.implementation_name.empty() ? "unknown"