)]}'
{
  "commit": "c929ab49b92a05b249bbabd6336a01e768ca92eb",
  "tree": "ab58179425557a07eb41b0a99dbeca7fc5c9883a",
  "parents": [
    "d05967cf4a1a5a092926fff729134e8588d7a133"
  ],
  "author": {
    "name": "Henrik Boström",
    "email": "hbos@webrtc.org",
    "time": "Thu Jun 15 13:17:45 2023"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Sat Jun 17 15:41:44 2023"
  },
  "message": "Reland \"[Stats] Remove enum-like structs in favor of strings.\"\n\nThis is a reland of commit ccc87ea3c625e43ab138e00ba2ef1a2d99756199\n\nDownstream project has been updated.\n\nOriginal change\u0027s description:\n\u003e [Stats] Remove enum-like structs in favor of strings.\n\u003e\n\u003e Due to a limitation of RTCStatsMember\u003cT\u003e not supporting enums, as well\n\u003e as the fact that in JavaScript enums are represented as basic strings,\n\u003e the stats enums have always been represented by T\u003dstd::string.\n\u003e\n\u003e Now that we have WebIDL-ified[1] all RTCStats dictionaries and enum\n\u003e values are simply string-copied (example: [2]) it seems safe to assume\n\u003e that \"stats enums are just strings\" is here to stay.\n\u003e\n\u003e Therefore there is little value in having C++ structs that look like\n\u003e enums so I\u0027m deleting those in favor of std::string operator\u003d\u003d()\n\u003e comparisons, e.g. `if (rtp_stream.kind \u003d\u003d \"audio\")`. This removes some\n\u003e lines of code from our code base.\n\u003e\n\u003e I mostly want to get rid of these because they were taking up about 20%\n\u003e of the rtcstats_objects.h real estate...\n\u003e\n\u003e [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/peerconnection/rtc_stats_report.idl\n\u003e [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc;l\u003d667;drc\u003dcf34e84c9df94256abfb1716ba075ed203975755\n\u003e\n\u003e Bug: webrtc:15245\n\u003e Change-Id: Iaf0827d7aecebc1cc02976a61663d5298d684f07\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308680\n\u003e Commit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\n\u003e Reviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#40295}\n\nBug: webrtc:15245\nChange-Id: Ibc7aeb518ed0bd7f1d725f140132c99e5a89bcf3\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/308880\nAuto-Submit: Henrik Boström \u003chbos@webrtc.org\u003e\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCommit-Queue: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#40305}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "58ca165d82236769e8d0c17b9785fdd2ee3ab6df",
      "old_mode": 33188,
      "old_path": "api/stats/rtcstats_objects.h",
      "new_id": "36013928ec751f52f9e585370f94baf69cd7f07e",
      "new_mode": 33188,
      "new_path": "api/stats/rtcstats_objects.h"
    },
    {
      "type": "modify",
      "old_id": "a71b5138659623fad2d8fe66085b891e3b16a7bb",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_bundle_unittest.cc",
      "new_id": "7edbe893167b1f2d579b6e8b98860f5fff25bb27",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_bundle_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "48e854252aebff6b9184f5ac8d3f311311bc650f",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector.cc",
      "new_id": "8cba02b5cedd0fc2da9ae04cde837f546d6a9d4c",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector.cc"
    },
    {
      "type": "modify",
      "old_id": "a8111bf8b21fb9e42af945737f377cf98a650800",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector_unittest.cc",
      "new_id": "a9f326f96a540ee2acba93254534af0d6d52beb4",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "67cb1c58f2e905a2c704dcad67e6c73899a4821f",
      "old_mode": 33188,
      "old_path": "stats/rtcstats_objects.cc",
      "new_id": "31720ad33f5f39c98fe7573c80ca0b0c685c5dc9",
      "new_mode": 33188,
      "new_path": "stats/rtcstats_objects.cc"
    },
    {
      "type": "modify",
      "old_id": "49e165795ad0274201a4718052cc8e5ce113341e",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/analyzer/audio/default_audio_quality_analyzer.cc",
      "new_id": "09fd7c8a82e892ca5de38f32ff965b0108f300b7",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/analyzer/audio/default_audio_quality_analyzer.cc"
    },
    {
      "type": "modify",
      "old_id": "224eb0c59f99c2edfe81f4a3164e705d252f3f9a",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc",
      "new_id": "817b3caad0cd8c2803a450396ea8850e2de0b990",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc"
    },
    {
      "type": "modify",
      "old_id": "549eafd95a62af527f18d8a011311673b84db73e",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/cross_media_metrics_reporter.cc",
      "new_id": "aad5946c9fb0c378de49301688bc6dc3ad11de9e",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/cross_media_metrics_reporter.cc"
    }
  ]
}