commit ce0302821672796bd96253acc5c83a05174449db
author Mirko Bonadei <mbonadei@webrtc.org> Thu Sep 01 16:19:42 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 01 17:20:57 2022
tree 50b66efdfab402fb79ac9158130de159f40a55f6
parent 7baa63ff9c35f2f0d9845316031bb33b859cd216

Add -Wctad-maybe-unsupported.

This will allow to catch issues (like the one that caused the revert
[1]) at CQ time.

[1] - https://webrtc-review.googlesource.com/c/src/+/273486

Bug: None
Change-Id: Ib12c15dcdc3e2a358d40c1a2ffabfbf42274e978
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273660
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37982}

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 31ee99b..92941f0 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -318,9 +318,15 @@
     defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ]
   }
 
-  # TODO(webrtc:13219): Fix -Wshadow instances and enable.
   if (is_clang) {
-    cflags += [ "-Wno-shadow" ]
+    cflags += [
+      # TODO(webrtc:13219): Fix -Wshadow instances and enable.
+      "-Wno-shadow",
+
+      # See https://reviews.llvm.org/D56731 for details about this
+      # warning.
+      "-Wctad-maybe-unsupported",
+    ]
   }
 
   if (build_with_chromium) {

modules/desktop_capture/linux/wayland/shared_screencast_stream.cc

diff --git a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
index 99cfa6f..0ca75d0 100644
--- a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
+++ b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
@@ -850,7 +850,8 @@
 rtc::scoped_refptr<SharedScreenCastStream>
 SharedScreenCastStream::CreateDefault() {
   // Explicit new, to access non-public constructor.
-  return rtc::scoped_refptr(new SharedScreenCastStream());
+  return rtc::scoped_refptr<SharedScreenCastStream>(
+      new SharedScreenCastStream());
 }
 
 bool SharedScreenCastStream::StartScreenCastStream(uint32_t stream_node_id) {