Revert of Refactor webrtc/modules/video_processing for GN check (patchset #3 id:40001 of https://codereview.webrtc.org/2595543002/ )
Reason for revert:
This CL broke some buildbots. I will investigate it later.
Original issue's description:
> Refactor webrtc/modules/video_processing for GN check
>
> This moves some GN check configurations out of .gn to individual
> targets.
>
> The now checked target is:
> "//webrtc/modules/video_processing/*"
>
> BUG=webrtc:6828
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2595543002
> Cr-Commit-Position: refs/heads/master@{#15732}
> Committed: https://chromium.googlesource.com/external/webrtc/+/00a810b844b2393b64f7e36ce1524dd9e3dccb4b
TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2594973002
Cr-Commit-Position: refs/heads/master@{#15733}
diff --git a/.gn b/.gn
index 40a182f..961190d 100644
--- a/.gn
+++ b/.gn
@@ -33,7 +33,6 @@
"//webrtc/modules/pacing/*",
"//webrtc/modules/video_capture/*",
"//webrtc/modules/video_coding/*",
- "//webrtc/modules/video_processing/*",
"//webrtc/stats:rtc_stats",
"//webrtc/voice_engine",
"//webrtc/voice_engine:level_indicator",
diff --git a/webrtc/modules/video_processing/BUILD.gn b/webrtc/modules/video_processing/BUILD.gn
index d4faf25..b1ab8ec 100644
--- a/webrtc/modules/video_processing/BUILD.gn
+++ b/webrtc/modules/video_processing/BUILD.gn
@@ -26,7 +26,6 @@
]
deps = [
- "../../base:rtc_base_approved",
"../../common_audio",
"../../common_video",
"../../modules/utility",
@@ -47,20 +46,11 @@
if (build_video_processing_sse2) {
rtc_static_library("video_processing_sse2") {
- # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
- # Errors on cyclic dependency with :video_processing if enabled.
- check_includes = false
-
sources = [
"util/denoiser_filter_sse2.cc",
"util/denoiser_filter_sse2.h",
]
- deps = [
- "../../base:rtc_base_approved",
- "../../system_wrappers",
- ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
