commit | 425a6ccac3c6c485048685566b259c540280cc2a | [log] [tgz] |
---|---|---|
author | ossu <ossu@webrtc.org> | Wed Oct 05 15:44:22 2016 |
committer | Commit bot <commit-bot@chromium.org> | Wed Oct 05 15:44:30 2016 |
tree | 422ad34e98f1d99ee78fdd52c166d7bb674a0743 | |
parent | b2d1e0d1daf41a158cde8a4519eb81d44603d78c [diff] |
RTPReceiverAudio: Removed frequency from CNGPayloadType and cleaned up CheckPayloadChanged. Removed last_received_frequency_, cng_payload_type_, g722_payload_type_ and last_received_g722_ from RTPReceiverAudio and cleaned up most of the related, now dead code. Since g722_payload_type_ was never set, neither was last_received_g722_, which means the frequency change in CNGPayloadType was never done. Setting the frequency to the standard values also proved unnecessary, since they were already set before the call. Even if frequency would have been changed by RTPReceiverAudio, I was not able to find a place where that would actually have mattered. The ACM and NetEq, for example, which eventually gets these packages, don't care about that value. Also, GetPayloadTypeFrequency was never called, so keeping track of last_received_frequency_ proved unnecessary. cng_payload_type_ was stored to be able to check in CNGPayloadType if cng_payload_type_has_changed. This flag was also never read, so these all disappear. The main reason for starting this change was to root out any G722 specific code we have sprinkled around the code base (specifically dealing with the fact that for G722 clock rate != sample rate). In this case, once I started pulling at one end of the string, the whole thing came unraveled. BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2383103002 Cr-Commit-Position: refs/heads/master@{#14530}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.