Delete NACK-related methods from AudioCodingModule Unused since cl https://webrtc-review.googlesource.com/c/src/+/111504 Bug: None Change-Id: I210f9c286961a2aec73c7e5c4cf8d04160f5a190 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148076 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28827}
diff --git a/modules/audio_coding/acm2/acm_receiver.h b/modules/audio_coding/acm2/acm_receiver.h index 8d54cf7..f07f8a9 100644 --- a/modules/audio_coding/acm2/acm_receiver.h +++ b/modules/audio_coding/acm2/acm_receiver.h
@@ -175,13 +175,12 @@ // Enable NACK and set the maximum size of the NACK list. If NACK is already // enabled then the maximum NACK list size is modified accordingly. // - // Input: - // -max_nack_list_size : maximum NACK list size - // should be positive (none zero) and less than or - // equal to |Nack::kNackListSizeLimit| - // Return value - // : 0 if succeeded. - // -1 if failed + // If the sequence number of last received packet is N, the sequence numbers + // of NACK list are in the range of [N - |max_nack_list_size|, N). + // + // |max_nack_list_size| should be positive (none zero) and less than or + // equal to |Nack::kNackListSizeLimit|. Otherwise, No change is applied and -1 + // is returned. 0 is returned at success. // int EnableNack(size_t max_nack_list_size); @@ -189,11 +188,13 @@ void DisableNack(); // - // Get a list of packets to be retransmitted. + // Get a list of packets to be retransmitted. |round_trip_time_ms| is an + // estimate of the round-trip-time (in milliseconds). Missing packets which + // will be playout in a shorter time than the round-trip-time (with respect + // to the time this API is called) will not be included in the list. // - // Input: - // -round_trip_time_ms : estimate of the round-trip-time (in milliseconds). - // Return value : list of packets to be retransmitted. + // Negative |round_trip_time_ms| results is an error message and empty list + // is returned. // std::vector<uint16_t> GetNackList(int64_t round_trip_time_ms) const;