)]}' { "commit": "e5ad5ca06ab3bfaaecd6dcfa01d136c4e5d8e9b2", "tree": "e4d498cabe9e642f40f85dc5e2aeb7916dac2298", "parents": [ "1dcb16409a3e82518ef852ec5614f87dff04f248" ], "author": { "name": "nisse", "email": "nisse@webrtc.org", "time": "Thu Mar 30 06:57:43 2017" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 30 06:57:43 2017" }, "message": "Reland of Don\u0027t hardcode MediaType::ANY in FakeNetworkPipe. (patchset #1 id:1 of https://codereview.webrtc.org/2784543002/ )\n\nReason for revert:\nIntend to fix perf failures and reland.\n\nOriginal issue\u0027s description:\n\u003e Revert of Don\u0027t hardcode MediaType::ANY in FakeNetworkPipe. (patchset #4 id:60001 of https://codereview.webrtc.org/2774463003/ )\n\u003e\n\u003e Reason for revert:\n\u003e Reverting since this seems to break multiple WebRTC Perf buildbots\n\u003e\n\u003e Original issue\u0027s description:\n\u003e \u003e Don\u0027t hardcode MediaType::ANY in FakeNetworkPipe.\n\u003e \u003e\n\u003e \u003e Instead let each test set the appropriate media type. This simplifies\n\u003e \u003e demuxing in Call and later in RtpTransportController.\n\u003e \u003e\n\u003e \u003e BUG\u003dwebrtc:7135\n\u003e \u003e\n\u003e \u003e Review-Url: https://codereview.webrtc.org/2774463003\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#17418}\n\u003e \u003e Committed: https://chromium.googlesource.com/external/webrtc/+/9c47b00e24da2941eb095df5a4459c6d98a8a88d\n\u003e\n\u003e TBR\u003dstefan@webrtc.org,deadbeef@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,sprang@webrtc.org,nisse@webrtc.org\n\u003e # Skipping CQ checks because original CL landed less than 1 days ago.\n\u003e NOPRESUBMIT\u003dtrue\n\u003e NOTREECHECKS\u003dtrue\n\u003e NOTRY\u003dtrue\n\u003e BUG\u003dwebrtc:7135\n\u003e\n\u003e Review-Url: https://codereview.webrtc.org/2784543002\n\u003e Cr-Commit-Position: refs/heads/master@{#17427}\n\u003e Committed: https://chromium.googlesource.com/external/webrtc/+/3a3bd5061089da5327fc549337a8430054d66057\n\nTBR\u003dstefan@webrtc.org,deadbeef@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,sprang@webrtc.org,lliuu@webrtc.org\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\nBUG\u003dwebrtc:7135\n\nReview-Url: https://codereview.webrtc.org/2783853002\nCr-Commit-Position: refs/heads/master@{#17459}\n", "tree_diff": [ { "type": "modify", "old_id": "c1b1a02235610b51cfa708aa934eb6183ccc3275", "old_mode": 33188, "old_path": "webrtc/audio/test/low_bandwidth_audio_test.cc", "new_id": "50d7e674e83d11833f43808e6572cc86c2df842b", "new_mode": 33188, "new_path": "webrtc/audio/test/low_bandwidth_audio_test.cc" }, { "type": "modify", "old_id": "bb4960f658efbe2ef919032a5cfe9cc17aac7498", "old_mode": 33188, "old_path": "webrtc/call/bitrate_estimator_tests.cc", "new_id": "00a3b9e833eca62ab686dbfa2e97a15f2f42f605", "new_mode": 33188, "new_path": "webrtc/call/bitrate_estimator_tests.cc" }, { "type": "modify", "old_id": "94acc9ff9dd99a4df52bd6a4ad27568ee6e5ebfc", "old_mode": 33188, "old_path": "webrtc/call/call.cc", "new_id": "396d3c9e0a263c6fc2c9d6ea07a155eb98de0cc8", "new_mode": 33188, "new_path": "webrtc/call/call.cc" }, { "type": "modify", "old_id": "bd5ab0ff253a63d319a02d336432ac54bb53185c", "old_mode": 33188, "old_path": "webrtc/call/call_perf_tests.cc", "new_id": "d62bec14907969a83e7e0e3c3ef518b92fd63e8e", "new_mode": 33188, "new_path": "webrtc/call/call_perf_tests.cc" }, { "type": "modify", "old_id": "292edc60836b4533d7ce5cb2c45fbee869821bd6", "old_mode": 33188, "old_path": "webrtc/call/rampup_tests.cc", "new_id": "0a2a7384d8dd7d0ad1eec0a1c68a88ee3b8b939c", "new_mode": 33188, "new_path": "webrtc/call/rampup_tests.cc" }, { "type": "modify", "old_id": "6710dd12f8f4f45fdc1893f81c9dd457cce3849d", "old_mode": 33188, "old_path": "webrtc/call/rampup_tests.h", "new_id": "5b24536aed1c34026e4316f1e30d9873a03eae1b", "new_mode": 33188, "new_path": "webrtc/call/rampup_tests.h" }, { "type": "modify", "old_id": "9a05ae67e4a72669a6881fa29b2eebea46d060b5", "old_mode": 33188, "old_path": "webrtc/media/engine/fakewebrtccall.cc", "new_id": "f442a3cc61bf0ee5218d1b29d9ce61767fecb928", "new_mode": 33188, "new_path": "webrtc/media/engine/fakewebrtccall.cc" }, { "type": "modify", "old_id": "3a13eeef862a802e17a3ba7432b809e433024bba", "old_mode": 33188, "old_path": "webrtc/test/call_test.cc", "new_id": "75595ab01163069ae208876a0c341c528a7b5b98", "new_mode": 33188, "new_path": "webrtc/test/call_test.cc" }, { "type": "modify", "old_id": "78fbbfbe4372d98a8a3ad0172472723dda8a0786", "old_mode": 33188, "old_path": "webrtc/test/call_test.h", "new_id": "b4f665821ee2ffa420a6465835a4dc310e8b3961", "new_mode": 33188, "new_path": "webrtc/test/call_test.h" }, { "type": "modify", "old_id": "922874d11142494349edd7ae581d66b0a531f757", "old_mode": 33188, "old_path": "webrtc/test/direct_transport.cc", "new_id": "90531eadfaf2ced07fefa87f9baf245496ec662d", "new_mode": 33188, "new_path": "webrtc/test/direct_transport.cc" }, { "type": "modify", "old_id": "eb552c57c8e29b52bcb1f562d6f36bd98d4266dd", "old_mode": 33188, "old_path": "webrtc/test/direct_transport.h", "new_id": "20a6857182b71d545b0d742df3aea61aa31138df", "new_mode": 33188, "new_path": "webrtc/test/direct_transport.h" }, { "type": "modify", "old_id": "8f2fee6c2c154eb63e192f8536d54f7717ff404f", "old_mode": 33188, "old_path": "webrtc/test/fake_network_pipe.cc", "new_id": "103416779a7ffdc8d15f6d7685505f4c2c4a6292", "new_mode": 33188, "new_path": "webrtc/test/fake_network_pipe.cc" }, { "type": "modify", "old_id": "0c73e85e1edfa829d7dfa25524479a024de107c8", "old_mode": 33188, "old_path": "webrtc/test/fake_network_pipe.h", "new_id": "adf76c3a7bae731b05b6498aa792c747d0d96797", "new_mode": 33188, "new_path": "webrtc/test/fake_network_pipe.h" }, { "type": "modify", "old_id": "aa273995945be93715ce66427e3e6a0e2aea9dc2", "old_mode": 33188, "old_path": "webrtc/test/fake_network_pipe_unittest.cc", "new_id": "c19b0014bb9f6cac21ce2a9d2bb1aa11bebb69e2", "new_mode": 33188, "new_path": "webrtc/test/fake_network_pipe_unittest.cc" }, { "type": "modify", "old_id": "26805539b9d142f40bb033513d509e21f6386954", "old_mode": 33188, "old_path": "webrtc/test/layer_filtering_transport.cc", "new_id": "5ae06b7305d6e8647754795981ae09b62985ee3f", "new_mode": 33188, "new_path": "webrtc/test/layer_filtering_transport.cc" }, { "type": "modify", "old_id": "8e1375f20fb06ccc6c509c149c24d7a211a21818", "old_mode": 33188, "old_path": "webrtc/test/rtp_rtcp_observer.h", "new_id": "b268e4ba026d83ef316526a30a5b3e00e6d99764", "new_mode": 33188, "new_path": "webrtc/test/rtp_rtcp_observer.h" }, { "type": "modify", "old_id": "6f030c3b58ff6cc136f6b3ed10c9398a73ac155d", "old_mode": 33188, "old_path": "webrtc/video/end_to_end_tests.cc", "new_id": "12b0b5297343d6b9f6243689c8f128c277570553", "new_mode": 33188, "new_path": "webrtc/video/end_to_end_tests.cc" }, { "type": "modify", "old_id": "2188d3e81d3a2bddbaec60fd722c328ba184ca5d", "old_mode": 33188, "old_path": "webrtc/video/replay.cc", "new_id": "6347dc9977bdca8e8352315a51f74e829325de11", "new_mode": 33188, "new_path": "webrtc/video/replay.cc" }, { "type": "modify", "old_id": "4c3c731dd79831ce817e3cdb4f18871126c0b42b", "old_mode": 33188, "old_path": "webrtc/video/video_quality_test.cc", "new_id": "96a488298e859229bbe2a80556c9b1f332e2f266", "new_mode": 33188, "new_path": "webrtc/video/video_quality_test.cc" }, { "type": "modify", "old_id": "cf09b3ac6cea9e5472db5328c395b3e9354713c7", "old_mode": 33188, "old_path": "webrtc/video/video_send_stream_tests.cc", "new_id": "18bb9b8e127bd18d7ab23b714a8c6920175c60a2", "new_mode": 33188, "new_path": "webrtc/video/video_send_stream_tests.cc" } ] }