Google Git
Sign in
webrtc / src.git / 0a16276290227c2611a685b99286e92927c531e8
commit0a16276290227c2611a685b99286e92927c531e8[log] [tgz]
authorHenrik Boström <hbos@webrtc.org>Mon May 02 13:47:52 2022
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 02 18:07:24 2022
treea3e8bae30ca2961b97b8eecb97a7ce237ee2c927
parent548102642d49174ead380e07fc9480b0c6595912 [diff]
Restore FiredDirection and maybe fire OnTrack in Rollback.

Prior to this CL, rollback did not restore FiredDirection and remote
streams were only sometimes restored. This resulted in not firing
ontrack if a track was rolled back and then added again on the same
transceiver.

Rollback also never performed OnTrack, which is incorrect because a
transceiver that goes from sendrecv to inactive will cause OnRemoveTrack
and if this is rolled back (so we become sendrecv again) then we need
OnTrack to fire.

This CL improves rollback's "memory", fires ontrack in Rollback() and
adds test coverage.

Needed to solve similar bugs in the Chromium layers as well:
https://chromium-review.googlesource.com/c/chromium/src/+/3613313

Bug: chromium:1320669
Change-Id: I655dd7d8a6b86080fe0e7c32c9e8c6434062ae91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260330
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36734}
6 files changed
tree: a3e8bae30ca2961b97b8eecb97a7ce237ee2c927
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. g3doc/
  11. infra/
  12. logging/
  13. media/
  14. modules/
  15. net/
  16. p2p/
  17. pc/
  18. resources/
  19. rtc_base/
  20. rtc_tools/
  21. sdk/
  22. stats/
  23. system_wrappers/
  24. test/
  25. tools_webrtc/
  26. video/
  27. .clang-format
  28. .git-blame-ignore-revs
  29. .gitignore
  30. .gn
  31. .mailmap
  32. .style.yapf
  33. .vpython
  34. .vpython3
  35. AUTHORS
  36. BUILD.gn
  37. CODE_OF_CONDUCT.md
  38. codereview.settings
  39. DEPS
  40. DIR_METADATA
  41. ENG_REVIEW_OWNERS
  42. g3doc.lua
  43. LICENSE
  44. license_template.txt
  45. native-api.md
  46. OWNERS
  47. PATENTS
  48. PRESUBMIT.py
  49. presubmit_test.py
  50. presubmit_test_mocks.py
  51. pylintrc
  52. README.chromium
  53. README.md
  54. WATCHLISTS
  55. webrtc.gni
  56. webrtc_lib_link_test.cc
  57. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info