commit f3a381adcdb574894e2f6939219191ef677abc95
author Henrik Boström <hbos@webrtc.org> Thu Jan 27 09:02:14 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 27 11:09:24 2022
tree eb4876ed05aa02105b67c20fae6c790f011924b0
parent 4cad08ff199a46087f8ffe91ef89af60a4dc8df9

Use kHigh timer precision for 'delayed-ack' timers.

In SCTP, sending ACKs at the right time is presumably important in order
not to cause unnecessary retransmissions.

This CL sets the ACK timers to use high timer precision. This unblocks
experimentally lowering the precision of the default, "low", timers in
WebRTC.

// All bots are green, but mac_chromium_compile is randomly timing out
// independently of this CL and has been doing so for several days...
NOTRY=True

Bug: webrtc:13604
Change-Id: I1c81e3d0eeb477c3e00277d35649114c5edd249c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249090
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35813}

net/dcsctp/socket/BUILD.gn

diff --git a/net/dcsctp/socket/BUILD.gn b/net/dcsctp/socket/BUILD.gn
index e8c64b0..083adaa 100644
--- a/net/dcsctp/socket/BUILD.gn
+++ b/net/dcsctp/socket/BUILD.gn
@@ -98,6 +98,7 @@
     ":packet_sender",
     ":stream_reset_handler",
     "../../../api:array_view",
+    "../../../api/task_queue:task_queue",
     "../../../rtc_base",
     "../../../rtc_base:checks",
     "../../../rtc_base:rtc_base_approved",

net/dcsctp/socket/transmission_control_block.h

diff --git a/net/dcsctp/socket/transmission_control_block.h b/net/dcsctp/socket/transmission_control_block.h
index 6d9dfc5..8cefbc6 100644
--- a/net/dcsctp/socket/transmission_control_block.h
+++ b/net/dcsctp/socket/transmission_control_block.h
@@ -19,6 +19,7 @@
 
 #include "absl/functional/bind_front.h"
 #include "absl/strings/string_view.h"
+#include "api/task_queue/task_queue_base.h"
 #include "net/dcsctp/common/sequence_numbers.h"
 #include "net/dcsctp/packet/chunk/cookie_echo_chunk.h"
 #include "net/dcsctp/packet/sctp_packet.h"
@@ -78,7 +79,9 @@
                              this),
             TimerOptions(options.delayed_ack_max_timeout,
                          TimerBackoffAlgorithm::kExponential,
-                         /*max_restarts=*/0))),
+                         /*max_restarts=*/0,
+                         /*max_backoff_duration=*/absl::nullopt,
+                         webrtc::TaskQueueBase::DelayPrecision::kHigh))),
         my_verification_tag_(my_verification_tag),
         my_initial_tsn_(my_initial_tsn),
         peer_verification_tag_(peer_verification_tag),