commit f4c04286bc361011660492fc1860ea72d59165ec
author Johannes Kron <kron@webrtc.org> Wed Feb 15 10:05:33 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 15 12:40:12 2023
tree 51c091c55e3a6f7815448744eb70d32afcf8df9c
parent ea41da2f9fda56a5a40540ec3331f2bcf797e8ec

Fix WebRTC.Screenshare.DesktopCapturerFullscreenDetector logging issue

The histogram WebRTC.Screenshare.DesktopCapturerFullscreenDetector
incorrectly counted every time a presentation application was shared
instead of only counting sessions where the presentation was
presented in fullscreen. This bug affected Windows, macOS works as
intended.

Bug: chromium:1348011
Change-Id: I9e84e9d1f4310703ba94e2af2e35a52d74a25842
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293461
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39314}

modules/desktop_capture/cropping_window_capturer_win.cc

diff --git a/modules/desktop_capture/cropping_window_capturer_win.cc b/modules/desktop_capture/cropping_window_capturer_win.cc
index 5d99cb6..ab2f807 100644
--- a/modules/desktop_capture/cropping_window_capturer_win.cc
+++ b/modules/desktop_capture/cropping_window_capturer_win.cc
@@ -310,7 +310,8 @@
       full_screen_window_detector_
           ? full_screen_window_detector_->FindFullScreenWindow(selected_source)
           : 0;
-  if (full_screen_source != selected_source && !fullscreen_usage_logged_) {
+  if (full_screen_source && full_screen_source != selected_source &&
+      !fullscreen_usage_logged_) {
     fullscreen_usage_logged_ = true;
     LogDesktopCapturerFullscreenDetectorUsage();
   }