| commit | f8ee65ead6e16cbb1c4311b9fd596a3435ec2f9a | [log] [tgz] |
|---|---|---|
| author | sprang <sprang@webrtc.org> | Tue Feb 28 16:49:33 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Feb 28 16:49:33 2017 |
| tree | c82d2694846d790ad1ed805f54d833a78d49ba04 | |
| parent | ba08a140da6cee478c62cf61e857cfee1647bf95 [diff] |
Fix rare race in ViEEncoderTest.UMACpuLimitedResolutionInPercent The test aims to synchronize by waiting for the last sent frame, using sink_.WaitForEncodedFrame(). Then it stops the vie_encoder instance and finally reset the SendStatsProxy to trigger UMA stats to be registered. The problem is that the callback that triggers WaitForEncodedFrame() to release will call FrameSent() on the overuse detecter just after that, and so it may try to update the stats proxy while it is being deleted. To prevent this, simply destroy the vie_encoder instance too, so that we know that the task queue has been stopped. BUG=None Review-Url: https://codereview.webrtc.org/2720183004 Cr-Commit-Position: refs/heads/master@{#16914}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.