commit f9c295283746d6ff29dee9bea3d4d02ddee07e11
author Mirko Bonadei <mbonadei@webrtc.org> Wed Jul 04 09:47:33 2018
committer Commit Bot <commit-bot@chromium.org> Wed Jul 04 11:13:09 2018
tree 049a94900662093c05a0a5364e232bdb176258fc
parent e12c1fe8d99b51891f8b0e039e0972423024a562

Removing warning suppression flags in common_audio/.

Bug: webrtc:9251
Change-Id: I9cae182ceb5e6bd3d6a34dc1a336ee3900f4cc98
Reviewed-on: https://webrtc-review.googlesource.com/86946
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23839}

common_audio/BUILD.gn

diff --git a/common_audio/BUILD.gn b/common_audio/BUILD.gn
index 63756a4..04f6e82 100644
--- a/common_audio/BUILD.gn
+++ b/common_audio/BUILD.gn
@@ -81,10 +81,6 @@
     deps += [ ":common_audio_neon" ]
   }
 
-  if (is_win) {
-    cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.
-  }
-
   public_configs = [ ":common_audio_config" ]
 
   if (!build_with_chromium && is_clang) {
@@ -207,10 +203,6 @@
     ]
   }
 
-  if (is_win) {
-    cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.
-  }
-
   public_configs = [ ":common_audio_config" ]
   deps = [
     ":common_audio_c_arm_asm",

common_audio/real_fourier.cc

diff --git a/common_audio/real_fourier.cc b/common_audio/real_fourier.cc
index f01c8eb..7365844 100644
--- a/common_audio/real_fourier.cc
+++ b/common_audio/real_fourier.cc
@@ -31,7 +31,7 @@
 
 size_t RealFourier::FftLength(int order) {
   RTC_CHECK_GE(order, 0);
-  return static_cast<size_t>(1 << order);
+  return size_t{1} << order;
 }
 
 size_t RealFourier::ComplexLength(int order) {

common_audio/signal_processing/complex_fft.c

diff --git a/common_audio/signal_processing/complex_fft.c b/common_audio/signal_processing/complex_fft.c
index 36689b3..e2ac206 100644
--- a/common_audio/signal_processing/complex_fft.c
+++ b/common_audio/signal_processing/complex_fft.c
@@ -166,7 +166,7 @@
     /* The 1024-value is a constant given from the size of kSinTable1024[],
      * and should not be changed depending on the input parameter 'stages'
      */
-    n = 1 << stages;
+    n = ((size_t)1) << stages;
     if (n > 1024)
         return -1;