Fix possible deadlock when handling SCTP_SEND_FAILED_EVENT notification.

When processing an INIT for existing SCTP association, which may happen
when transferring to a new remote endpoint, if there are chunks still on
the output queue, an SCTP_SEND_FAILED_EVENT notification will be
delivered while holding the INP lock. When processing this notification,
WebRTC was calling usrsctp_getladdrs in order to look up the
SctpTransport* associated with the socket, but this also tries to
acquire the INP lock, resulting in a deadlock.

The temporary fix is to simply not subscribe to the
SCTP_SEND_FAILED_EVENT notification; it was only used for logging
anyway.

Bug: chromium:1137936
Change-Id: I077efb4c769d6f7855d2fee2d266f19396b16f9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188502
Commit-Queue: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32427}
2 files changed
tree: a8f9418b7129169c41e76780ff6c65174f96f272
  1. .clang-format
  2. .git-blame-ignore-revs
  3. .gitignore
  4. .gn
  5. .vpython
  6. AUTHORS
  7. BUILD.gn
  8. CODE_OF_CONDUCT.md
  9. DEPS
  10. ENG_REVIEW_OWNERS
  11. LICENSE
  12. OWNERS
  13. PATENTS
  14. PRESUBMIT.py
  15. README.chromium
  16. README.md
  17. WATCHLISTS
  18. abseil-in-webrtc.md
  19. api/
  20. audio/
  21. build_overrides/
  22. call/
  23. codereview.settings
  24. common_audio/
  25. common_video/
  26. data/
  27. docs/
  28. examples/
  29. license_template.txt
  30. logging/
  31. media/
  32. modules/
  33. native-api.md
  34. p2p/
  35. pc/
  36. presubmit_test.py
  37. presubmit_test_mocks.py
  38. pylintrc
  39. resources/
  40. rtc_base/
  41. rtc_tools/
  42. sdk/
  43. stats/
  44. style-guide.md
  45. style-guide/
  46. system_wrappers/
  47. test/
  48. tools_webrtc/
  49. video/
  50. webrtc.gni
  51. webrtc_lib_link_test.cc
  52. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info