| commit | 088a6f21927919b4cbba4b0ba2705b4211c1cb14 | [log] [tgz] |
|---|---|---|
| author | Taylor Brandstetter <deadbeef@webrtc.org> | Fri Oct 16 21:06:48 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 16 22:44:19 2020 |
| tree | a8f9418b7129169c41e76780ff6c65174f96f272 | |
| parent | fba124a4834642404935e743c882848238fbdaf3 [diff] |
Fix possible deadlock when handling SCTP_SEND_FAILED_EVENT notification. When processing an INIT for existing SCTP association, which may happen when transferring to a new remote endpoint, if there are chunks still on the output queue, an SCTP_SEND_FAILED_EVENT notification will be delivered while holding the INP lock. When processing this notification, WebRTC was calling usrsctp_getladdrs in order to look up the SctpTransport* associated with the socket, but this also tries to acquire the INP lock, resulting in a deadlock. The temporary fix is to simply not subscribe to the SCTP_SEND_FAILED_EVENT notification; it was only used for logging anyway. Bug: chromium:1137936 Change-Id: I077efb4c769d6f7855d2fee2d266f19396b16f9d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188502 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32427}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.