commit 3ff035e2787b7da182ee79e143da0b7ac099b4a8
author Harald Alvestrand <hta@webrtc.org> Tue Jun 17 19:42:56 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 18 06:00:41 2025
tree afed81999b6e6fc42f68141318e5eefedcd0f1e6
parent 4378a2bb74be14cc3ab3e6eea1a8a670017de260

Remove rtp_header_extensions_set()

It seems to be unused and useless.

Bug: webrtc:425296984
Change-Id: Iee68aec438889f8c1dd7ee69ea444606f17ff485
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/396860
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44968}

pc/channel.cc

diff --git a/pc/channel.cc b/pc/channel.cc
index 8b8d7a7..2b54806 100644
--- a/pc/channel.cc
+++ b/pc/channel.cc
@@ -99,11 +99,7 @@
              desc->type() == MediaType::VIDEO);
   params->is_stream_active = is_stream_active;
   params->codecs = desc->codecs();
-  // TODO: bugs.webrtc.org/11513 - See if we really need
-  // rtp_header_extensions_set() and remove it if we don't.
-  if (desc->rtp_header_extensions_set()) {
-    params->extensions = extensions;
-  }
+  params->extensions = extensions;
   params->rtcp.reduced_size = desc->rtcp_reduced_size();
   params->rtcp.remote_estimate = desc->remote_estimate();
 }

pc/session_description.h

diff --git a/pc/session_description.h b/pc/session_description.h
index 4a330c5..37272c4 100644
--- a/pc/session_description.h
+++ b/pc/session_description.h
@@ -135,18 +135,10 @@
   }
   void set_rtp_header_extensions(const RtpHeaderExtensions& extensions) {
     rtp_header_extensions_ = extensions;
-    rtp_header_extensions_set_ = true;
   }
   void AddRtpHeaderExtension(const RtpExtension& ext) {
     rtp_header_extensions_.push_back(ext);
-    rtp_header_extensions_set_ = true;
   }
-  // We can't always tell if an empty list of header extensions is
-  // because the other side doesn't support them, or just isn't hooked up to
-  // signal them. For now we assume an empty list means no signaling, but
-  // provide the ClearRtpHeaderExtensions method to allow "no support" to be
-  // clearly indicated (i.e. when derived from other information).
-  bool rtp_header_extensions_set() const { return rtp_header_extensions_set_; }
   const StreamParamsVec& streams() const { return send_streams_; }
   // TODO(pthatcher): Remove this by giving mediamessage.cc access
   // to MediaContentDescription
@@ -262,7 +254,6 @@
   std::string bandwidth_type_ = kApplicationSpecificBandwidth;
 
   std::vector<RtpExtension> rtp_header_extensions_;
-  bool rtp_header_extensions_set_ = false;
   StreamParamsVec send_streams_;
   bool conference_mode_ = false;
   RtpTransceiverDirection direction_ = RtpTransceiverDirection::kSendRecv;