dcsctp: Correct Fast Recovery retransmission logic

This commit fixes a logic error in OutstandingData that prevented the
correct application of Fast Recovery retransmission rules when the
Cumulative TSN Ack point advanced.

Previously, HandleSack would call RemoveAcked before
NackBetweenAckBlocks. Because RemoveAcked updates the internal
last_cumulative_tsn_ack_ to match the incoming SACK, the subsequent
check (cumulative_tsn_ack > last_cumulative_tsn_ack_) in
NackBetweenAckBlocks would always be false. This resulted in miss
indications not being incremented for all missing TSNs as required
during Fast Recovery.

Per RFC 9260 Section 7.2.4: "If an endpoint is in Fast Recovery and
a SACK chunks arrives that advances the Cumulative TSN Ack Point, the
miss indications are incremented for all TSNs reported missing in the
SACK chunk."

The fix involves determining if the cumulative ACK point is advancing
before the internal state is modified in HandleSack. A new unit test
FastRecoveryIncrementsNackCountWhenCumulativeTsnAdvances verifies
that missing TSNs correctly receive miss indications in this scenario.

No-Try: True
Bug: None
Change-Id: Ic8ef7026bfb3617bd2094bae47de13b9d0133930
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/448080
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46864}
3 files changed
tree: 1d74500335e69c8ae3e4642becf57658c1b15e45
  1. agents/
  2. api/
  3. audio/
  4. build_overrides/
  5. call/
  6. common_audio/
  7. common_video/
  8. data/
  9. docs/
  10. examples/
  11. experiments/
  12. g3doc/
  13. infra/
  14. logging/
  15. media/
  16. modules/
  17. net/
  18. p2p/
  19. pc/
  20. resources/
  21. rtc_base/
  22. rtc_tools/
  23. sdk/
  24. stats/
  25. system_wrappers/
  26. test/
  27. tools_webrtc/
  28. video/
  29. .clang-format
  30. .clang-tidy
  31. .git-blame-ignore-revs
  32. .gitignore
  33. .gn
  34. .mailmap
  35. .rustfmt.toml
  36. .style.yapf
  37. .vpython3
  38. AUTHORS
  39. BUILD.gn
  40. CODE_OF_CONDUCT.md
  41. codereview.settings
  42. DEPS
  43. DIR_METADATA
  44. ENG_REVIEW_OWNERS
  45. GEMINI.md
  46. LICENSE
  47. license_template.txt
  48. native-api.md
  49. OWNERS
  50. OWNERS_INFRA
  51. PATENTS
  52. PRESUBMIT.py
  53. presubmit_test.py
  54. presubmit_test_mocks.py
  55. pylintrc
  56. pylintrc_old_style
  57. README.chromium
  58. README.md
  59. unsafe_buffers_paths.txt
  60. WATCHLISTS
  61. webrtc.gni
  62. webrtc_lib_link_test.cc
  63. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info